Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2222163004: convert most webrtc builders to remote_run (Closed)

Created:
4 years, 4 months ago by Paweł Hajdan Jr.
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -28 lines) Patch
M masters/master.client.webrtc.fyi/master_android_cfg.py View 2 chunks +14 lines, -3 lines 0 comments Download
M masters/master.client.webrtc.fyi/master_linux_cfg.py View 2 chunks +18 lines, -2 lines 0 comments Download
M masters/master.client.webrtc.fyi/master_mac_cfg.py View 2 chunks +14 lines, -4 lines 0 comments Download
M masters/master.client.webrtc.fyi/master_win_cfg.py View 2 chunks +14 lines, -3 lines 0 comments Download
M masters/master.client.webrtc/master_android_cfg.py View 2 chunks +14 lines, -3 lines 0 comments Download
M masters/master.client.webrtc/master_linux_cfg.py View 2 chunks +18 lines, -2 lines 0 comments Download
M masters/master.client.webrtc/master_mac_cfg.py View 2 chunks +14 lines, -4 lines 2 comments Download
M masters/master.client.webrtc/master_win_cfg.py View 2 chunks +14 lines, -3 lines 0 comments Download
M masters/master.tryserver.webrtc/master.cfg View 2 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Paweł Hajdan Jr.
4 years, 4 months ago (2016-08-09 12:56:32 UTC) #2
kjellander_chromium
lgtm w/ question assuming I understood correctly that you had to keep annotator_factory for some ...
4 years, 4 months ago (2016-08-09 14:16:21 UTC) #7
Paweł Hajdan Jr.
https://codereview.chromium.org/2222163004/diff/1/masters/master.client.webrtc/master_mac_cfg.py File masters/master.client.webrtc/master_mac_cfg.py (right): https://codereview.chromium.org/2222163004/diff/1/masters/master.client.webrtc/master_mac_cfg.py#newcode16 masters/master.client.webrtc/master_mac_cfg.py:16: repository='https://chromium.googlesource.com/chromium/tools/build.git', On 2016/08/09 at 14:16:21, kjellander_chromium wrote: > This ...
4 years, 4 months ago (2016-08-09 15:04:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222163004/1
4 years, 4 months ago (2016-08-09 15:05:00 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 15:09:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/fd39eee639032f07ff57...

Powered by Google App Engine
This is Rietveld 408576698