Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 223513002: Mac AVfoundation: Change AVVideoScalingModeResizeAspect -> AVVideoScalingModeResizeAspectFill (Closed)

Created:
6 years, 8 months ago by mcasas
Modified:
6 years, 8 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, Robert Sesek
Visibility:
Public.

Description

Mac AVfoundation: Change AVVideoScalingModeResizeAspect -> AVVideoScalingModeResizeAspectFill AVCaptureVideoDataOutput uses AVVideoScalingModeResizeAspect to "Preserve aspect ratio of the source, and fill remaining areas with black to fit destination dimensions." [1]. However, in at least two cases, this seems to be problematic: - When capturing 480p using a Blackmagic Ultra Studio Mini Recorder. (http://crbug.com/347371). - When opening the camera in a 16:9 aspect ratio using AVFoundation _and then without closing it_ opening in a 4:3 aspect ratio with QTKit (http://crbug.com/357252). The solution in both cases is to instruct the AVCaptureVideoDataOutput to use AVVideoScalingModeResizeAspectFill: "Preserve aspect ratio of the source, and crop picture to fit destination dimensions" [1]. [1] https://developer.apple.com/library/mac/documentation/AVFoundation/Reference/AVFoundation_Constants/Reference/reference.html#jumpTo_75 BUG=288562, 357252, 347371 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261373

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M media/video/capture/mac/avfoundation_glue.h View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/mac/avfoundation_glue.mm View 4 chunks +7 lines, -6 lines 0 comments Download
M media/video/capture/mac/video_capture_device_avfoundation_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mcasas
tommi@ PTAL (minor patch).. rsesek@ FYI.
6 years, 8 months ago (2014-04-03 08:09:36 UTC) #1
tommi (sloooow) - chröme
lgtm
6 years, 8 months ago (2014-04-03 08:57:31 UTC) #2
mcasas
The CQ bit was checked by mcasas@chromium.org
6 years, 8 months ago (2014-04-03 09:41:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/223513002/20001
6 years, 8 months ago (2014-04-03 09:43:35 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 12:28:06 UTC) #5
Message was sent while issue was closed.
Change committed as 261373

Powered by Google App Engine
This is Rietveld 408576698