Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: media/video/capture/mac/video_capture_device_avfoundation_mac.mm

Issue 223513002: Mac AVfoundation: Change AVVideoScalingModeResizeAspect -> AVVideoScalingModeResizeAspectFill (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/video/capture/mac/avfoundation_glue.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/video/capture/mac/video_capture_device_avfoundation_mac.mm
diff --git a/media/video/capture/mac/video_capture_device_avfoundation_mac.mm b/media/video/capture/mac/video_capture_device_avfoundation_mac.mm
index dee6bc05e819543458633b3c43e91e17f4a2c512..2282f8ff22fd11dea2ad7b5d5a67702b843bb14f 100644
--- a/media/video/capture/mac/video_capture_device_avfoundation_mac.mm
+++ b/media/video/capture/mac/video_capture_device_avfoundation_mac.mm
@@ -207,13 +207,13 @@
// The reason for this mismatch is probably because most of the AVFoundation
// docs are written for iOS and not for MacOsX.
// AVVideoScalingModeKey() refers to letterboxing yes/no and preserve aspect
- // ratio yes/no when scaling. Currently we set letterbox and preservation.
+ // ratio yes/no when scaling. Currently we set cropping and preservation.
NSDictionary* videoSettingsDictionary = @{
(id)kCVPixelBufferWidthKey : @(width),
(id)kCVPixelBufferHeightKey : @(height),
(id)kCVPixelBufferPixelFormatTypeKey : @(kCVPixelFormatType_422YpCbCr8),
AVFoundationGlue::AVVideoScalingModeKey() :
- AVFoundationGlue::AVVideoScalingModeResizeAspect()
+ AVFoundationGlue::AVVideoScalingModeResizeAspectFill()
};
[captureVideoDataOutput_ setVideoSettings:videoSettingsDictionary];
« no previous file with comments | « media/video/capture/mac/avfoundation_glue.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698