Introduce SmiValuesAre31Bits and SmiValuesAre32Bits global predicate functions

Introduce SmiValuesAre31Bits and SmiValuesAre32Bits global predicate functions

R=danno@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16365

[haitao.feng, 2013-08-09 06:50:52]

Addressed danno's comment on https://codereview.chromium.org/21014003/. This
part could be separated from that big CL.

[danno, 2013-08-13 09:41:35]

I like this incremental step, please just change where the predicates are
defined as described below and then I think the CL will be ready.

https://chromiumcodereview.appspot.com/22350005/diff/1/include/v8.h
File include/v8.h (right):

https://chromiumcodereview.appspot.com/22350005/diff/1/include/v8.h#newcode5454
include/v8.h:5454: V8_INLINE(static bool SmiValuesAre32Bits()) { return
kApiPointerSize == 8; }
Please put this after "const int kSmiValueSize..." below, and use kSmiValueSize
== 31/32 as the comparison, I think it's a little clearer.

[haitao.feng, 2013-08-13 10:37:53]

danno, thanks for the review. I will commit this when the tree is open.

https://codereview.chromium.org/22350005/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/22350005/diff/1/include/v8.h#newcode5454
include/v8.h:5454: V8_INLINE(static bool SmiValuesAre32Bits()) { return
kApiPointerSize == 8; }
On 2013/08/13 09:41:36, danno wrote:
> Please put this after "const int kSmiValueSize..." below, and use
kSmiValueSize
> == 31/32 as the comparison, I think it's a little clearer.

Done.

[danno, 2013-08-19 18:35:42]

lgtm, but please wait to land until the tree is no longer throttled

[haitao.feng, 2013-08-20 13:21:33]

Thanks for the review. Sure I will wait for that.

[haitao.feng, 2013-08-27 14:13:59]

Committed patchset #2 manually as r16365 (presubmit successful).