Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/hydrogen-instructions.h

Issue 22350005: Introduce SmiValuesAre31Bits and SmiValuesAre32Bits global predicate functions (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « include/v8.h ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3249 matching lines...) Expand 10 before | Expand all | Expand 10 after
3260 3260
3261 bool IsCell() const { 3261 bool IsCell() const {
3262 return is_cell_; 3262 return is_cell_;
3263 } 3263 }
3264 3264
3265 virtual Representation RequiredInputRepresentation(int index) { 3265 virtual Representation RequiredInputRepresentation(int index) {
3266 return Representation::None(); 3266 return Representation::None();
3267 } 3267 }
3268 3268
3269 virtual Representation KnownOptimalRepresentation() { 3269 virtual Representation KnownOptimalRepresentation() {
3270 if (HasSmiValue() && kSmiValueSize == 31) return Representation::Smi(); 3270 if (HasSmiValue() && SmiValuesAre31Bits()) return Representation::Smi();
3271 if (HasInteger32Value()) return Representation::Integer32(); 3271 if (HasInteger32Value()) return Representation::Integer32();
3272 if (HasNumberValue()) return Representation::Double(); 3272 if (HasNumberValue()) return Representation::Double();
3273 if (HasExternalReferenceValue()) return Representation::External(); 3273 if (HasExternalReferenceValue()) return Representation::External();
3274 return Representation::Tagged(); 3274 return Representation::Tagged();
3275 } 3275 }
3276 3276
3277 virtual bool EmitAtUses(); 3277 virtual bool EmitAtUses();
3278 virtual void PrintDataTo(StringStream* stream); 3278 virtual void PrintDataTo(StringStream* stream);
3279 bool IsInteger() { return handle()->IsSmi(); } 3279 bool IsInteger() { return handle()->IsSmi(); }
3280 HConstant* CopyToRepresentation(Representation r, Zone* zone) const; 3280 HConstant* CopyToRepresentation(Representation r, Zone* zone) const;
(...skipping 2408 matching lines...) Expand 10 before | Expand all | Expand 10 after
5689 class ArrayInstructionInterface { 5689 class ArrayInstructionInterface {
5690 public: 5690 public:
5691 virtual HValue* GetKey() = 0; 5691 virtual HValue* GetKey() = 0;
5692 virtual void SetKey(HValue* key) = 0; 5692 virtual void SetKey(HValue* key) = 0;
5693 virtual void SetIndexOffset(uint32_t index_offset) = 0; 5693 virtual void SetIndexOffset(uint32_t index_offset) = 0;
5694 virtual bool IsDehoisted() = 0; 5694 virtual bool IsDehoisted() = 0;
5695 virtual void SetDehoisted(bool is_dehoisted) = 0; 5695 virtual void SetDehoisted(bool is_dehoisted) = 0;
5696 virtual ~ArrayInstructionInterface() { }; 5696 virtual ~ArrayInstructionInterface() { };
5697 5697
5698 static Representation KeyedAccessIndexRequirement(Representation r) { 5698 static Representation KeyedAccessIndexRequirement(Representation r) {
5699 return r.IsInteger32() || kSmiValueSize != 31 5699 return r.IsInteger32() || SmiValuesAre32Bits()
5700 ? Representation::Integer32() : Representation::Smi(); 5700 ? Representation::Integer32() : Representation::Smi();
5701 } 5701 }
5702 }; 5702 };
5703 5703
5704 5704
5705 enum LoadKeyedHoleMode { 5705 enum LoadKeyedHoleMode {
5706 NEVER_RETURN_HOLE, 5706 NEVER_RETURN_HOLE,
5707 ALLOW_RETURN_HOLE 5707 ALLOW_RETURN_HOLE
5708 }; 5708 };
5709 5709
(...skipping 1068 matching lines...) Expand 10 before | Expand all | Expand 10 after
6778 virtual bool IsDeletable() const { return true; } 6778 virtual bool IsDeletable() const { return true; }
6779 }; 6779 };
6780 6780
6781 6781
6782 #undef DECLARE_INSTRUCTION 6782 #undef DECLARE_INSTRUCTION
6783 #undef DECLARE_CONCRETE_INSTRUCTION 6783 #undef DECLARE_CONCRETE_INSTRUCTION
6784 6784
6785 } } // namespace v8::internal 6785 } } // namespace v8::internal
6786 6786
6787 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6787 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « include/v8.h ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698