Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2234913002: Added support for header and footer inside other sections, according to HTML API Mappings 1.0. (Closed)

Created:
4 years, 4 months ago by nektarios
Modified:
4 years, 4 months ago
Reviewers:
dmazzoni
CC:
dmazzoni, aboxhall, aboxhall+watch_chromium.org, blink-reviews, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, haraken, jam, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added support for header and footer inside other sections, according to HTML API Mappings 1.0. One of the criteria on html5accessibility.com. BUG=628533 R=dmazzoni@chromium.org TESTED=browser tests, manually with tests provided by html5accessibility.com Committed: https://crrev.com/47b9be5bfce50b7df582dade75f9102fb9599bbb Cr-Commit-Position: refs/heads/master@{#411452}

Patch Set 1 #

Patch Set 2 : Header and footer elements should never be ignored. #

Patch Set 3 : Checked if node if present. #

Total comments: 2

Patch Set 4 : Added back files. #

Patch Set 5 : Added tests and fixed layout test. #

Patch Set 6 : Fixed test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -15 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/footer-inside-other-section.html View 3 1 chunk +21 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/footer-inside-other-section-expected-android.txt View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/footer-inside-other-section-expected-mac.txt View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/footer-inside-other-section-expected-win.txt View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/header-inside-other-section.html View 3 1 chunk +21 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/header-inside-other-section-expected-android.txt View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/header-inside-other-section-expected-mac.txt View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/header-inside-other-section-expected-win.txt View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/element-role-mapping-normal-expected.txt View 1 2 3 4 3 chunks +16 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 3 1 chunk +13 lines, -3 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
nektarios
4 years, 4 months ago (2016-08-10 16:06:54 UTC) #1
dmazzoni
https://codereview.chromium.org/2234913002/diff/40001/ios/build/util/CANARY_VERSION File ios/build/util/CANARY_VERSION (right): https://codereview.chromium.org/2234913002/diff/40001/ios/build/util/CANARY_VERSION#newcode1 ios/build/util/CANARY_VERSION:1: PATCH=1529 Revert this https://codereview.chromium.org/2234913002/diff/40001/ui/accessibility/ax_position.h File ui/accessibility/ax_position.h (right): https://codereview.chromium.org/2234913002/diff/40001/ui/accessibility/ax_position.h#newcode5 ui/accessibility/ax_position.h:5: ...
4 years, 4 months ago (2016-08-10 20:45:52 UTC) #6
blink-reviews
All fixed except test expectations. Waiting on bots to run. -- You received this message ...
4 years, 4 months ago (2016-08-11 00:13:16 UTC) #7
chromium-reviews
All fixed except test expectations. Waiting on bots to run. -- You received this message ...
4 years, 4 months ago (2016-08-11 00:13:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234913002/90001
4 years, 4 months ago (2016-08-11 15:35:19 UTC) #16
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-11 15:35:21 UTC) #18
nektarios
All issues fixed.
4 years, 4 months ago (2016-08-11 15:36:15 UTC) #19
dmazzoni
lgtm
4 years, 4 months ago (2016-08-11 20:46:51 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234913002/90001
4 years, 4 months ago (2016-08-11 22:03:48 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:90001)
4 years, 4 months ago (2016-08-11 23:51:07 UTC) #23
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 23:54:26 UTC) #25
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/47b9be5bfce50b7df582dade75f9102fb9599bbb
Cr-Commit-Position: refs/heads/master@{#411452}

Powered by Google App Engine
This is Rietveld 408576698