Ensure that createImageBitmap takes a snapshot of a gifs frame 0 image.

Ensure that createImageBitmap takes a snapshot of a gifs frame 0 image.

BUG=255610, 166658
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155785

[Justin Novosad, 2013-08-07 18:56:55]

https://codereview.chromium.org/22346004/diff/1/LayoutTests/fast/canvas/canva...
File LayoutTests/fast/canvas/canvas-createImageBitmap-animated.html (right):

https://codereview.chromium.org/22346004/diff/1/LayoutTests/fast/canvas/canva...
LayoutTests/fast/canvas/canvas-createImageBitmap-animated.html:14:
canvas.setAttribute("width", "200");
canvas.width = 200;

https://codereview.chromium.org/22346004/diff/1/LayoutTests/fast/canvas/canva...
LayoutTests/fast/canvas/canvas-createImageBitmap-animated.html:25:
ctx.drawImage(imageBitmap, 0, 0);
Instead of implementing this as a ref test, it could be a test with a text
baseline.  Right here you should just do a getImageData and check that you get
the right color back.

https://codereview.chromium.org/22346004/diff/1/LayoutTests/fast/canvas/canva...
LayoutTests/fast/canvas/canvas-createImageBitmap-animated.html:28: }, 200);
This 200ms seems to come out of nowhere.  I think you should put in some
comments that explain what the animation cycle of the gif looks like and why
200ms is a good delay for testing.  Also, keep in mind that testing performance
is important an we try to keep run times as short as possible.

[arbesfeld, 2013-08-07 19:11:11]

Done.

[Justin Novosad, 2013-08-07 19:24:45]

On 2013/08/07 19:11:11, arbesfeld wrote:
> Done.

lgtm.  Stephen?

[Stephen White, 2013-08-07 19:27:27]

LGTM

[commit-bot: I haz the power, 2013-08-07 21:56:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arbesfeld@chromium.org/22346004/7001

[commit-bot: I haz the power, 2013-08-07 21:56:34]

Can't process patch for file
LayoutTests/fast/canvas/resources/green-red-animated.gif.
Binary file support is temporarilly disabled due to a bug. Please commit blindly
the binary files first then commit the source change as a separate CL. Sorry for
the annoyance.

[commit-bot: I haz the power, 2013-08-08 15:11:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arbesfeld@chromium.org/22346004/15001

[commit-bot: I haz the power, 2013-08-08 20:49:50]

Change committed as 155785