LayoutTests/fast/canvas/canvas-createImageBitmap-animated.html - Issue 22346004: Ensure that createImageBitmap takes a snapshot of a gifs frame 0 image.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/canvas/canvas-createImageBitmap-animated.html

Issue 22346004: Ensure that createImageBitmap takes a snapshot of a gifs frame 0 image. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <body>

	3 <canvas id="c"></canvas>

	4 <script>

	5 if (window.testRunner)

	6 testRunner.waitUntilDone();

	7

	8 function finishTest() {

	9 if (window.testRunner)

	10 testRunner.notifyDone();

	11 }

	12

	13 var canvas = document.getElementById("c");

	14 canvas.setAttribute("width", "200");
	Justin Novosad 2013/08/07 18:56:55 canvas.width = 200; canvas.width = 200;
	15 canvas.setAttribute("height", "200");

	16 var ctx = canvas.getContext("2d");

	17

	18 var img = new Image();

	19 img.src = 'resources/green-red-animated.gif';

	20 img.onload = imageLoaded();

	21

	22 function imageLoaded() {

	23 window.setTimeout(function() {

	24 createImageBitmap(img).then(function (imageBitmap) {

	25 ctx.drawImage(imageBitmap, 0, 0);
	Justin Novosad 2013/08/07 18:56:55 Instead of implementing this as a ref test, it cou Instead of implementing this as a ref test, it could be a test with a text baseline. Right here you should just do a getImageData and check that you get the right color back.
	26 finishTest();

	27 }, finishTest);

	28 }, 200);
	Justin Novosad 2013/08/07 18:56:55 This 200ms seems to come out of nowhere. I think This 200ms seems to come out of nowhere. I think you should put in some comments that explain what the animation cycle of the gif looks like and why 200ms is a good delay for testing. Also, keep in mind that testing performance is important an we try to keep run times as short as possible.
	29 }

	30 </script>

	31 <p>A green square should be visible.</p>

	32 </body>

	33 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/canvas/canvas-createImageBitmap-animated-expected.html » ('j') | no next file with comments »