Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Issue 2234483002: SkLiteDL: add some missing std::move() (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkLiteDL: add some missing std::move() This cuts a ref+unref roundtrip on all draw{Bitmap,Image} I set this up originally and just... forgot. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234483002 Committed: https://skia.googlesource.com/skia/+/baeec6d25e02596f32d3307b5b4f88649dd2994f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/core/SkLiteDL.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
mtklein
lgtm
4 years, 4 months ago (2016-08-09 21:49:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234483002/1
4 years, 4 months ago (2016-08-09 21:49:33 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 22:09:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/baeec6d25e02596f32d3307b5b4f88649dd2994f

Powered by Google App Engine
This is Rietveld 408576698