Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: src/core/SkLiteDL.cpp

Issue 2234483002: SkLiteDL: add some missing std::move() (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkLiteDL.cpp
diff --git a/src/core/SkLiteDL.cpp b/src/core/SkLiteDL.cpp
index 8dad6f40e482c04ef4200a6f35a6c7d5bb6e714b..f4624c497b90d90ef1a057c65a893cd10d3ab47f 100644
--- a/src/core/SkLiteDL.cpp
+++ b/src/core/SkLiteDL.cpp
@@ -241,7 +241,7 @@ namespace {
struct DrawImage final : Op {
DrawImage(sk_sp<const SkImage>&& image, SkScalar x, SkScalar y, const SkPaint* paint)
- : image(image), x(x), y(y) {
+ : image(std::move(image)), x(x), y(y) {
if (paint) { this->paint = *paint; }
}
sk_sp<const SkImage> image;
@@ -253,7 +253,7 @@ namespace {
struct DrawImageNine final : Op {
DrawImageNine(sk_sp<const SkImage>&& image,
const SkIRect& center, const SkRect& dst, const SkPaint* paint)
- : image(image), center(center), dst(dst) {
+ : image(std::move(image)), center(center), dst(dst) {
if (paint) { this->paint = *paint; }
}
sk_sp<const SkImage> image;
@@ -266,7 +266,7 @@ namespace {
struct DrawImageRect final : Op {
DrawImageRect(sk_sp<const SkImage>&& image, const SkRect* src, const SkRect& dst,
const SkPaint* paint, SkCanvas::SrcRectConstraint constraint)
- : image(image), dst(dst), constraint(constraint) {
+ : image(std::move(image)), dst(dst), constraint(constraint) {
this->src = src ? *src : SkRect::MakeIWH(image->width(), image->height());
if (paint) { this->paint = *paint; }
}
@@ -282,7 +282,7 @@ namespace {
struct DrawImageLattice final : Op {
DrawImageLattice(sk_sp<const SkImage>&& image, int xs, int ys,
const SkRect& dst, const SkPaint* paint)
- : image(image), xs(xs), ys(ys), dst(dst) {
+ : image(std::move(image)), xs(xs), ys(ys), dst(dst) {
if (paint) { this->paint = *paint; }
}
sk_sp<const SkImage> image;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698