third_party/WebKit/Source/modules/webusb/USBDevice.h - Issue 2234443002: Mojo C++ binding: make device/usb mojom targets use STD string/vector types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webusb/USBDevice.h

Issue 2234443002: Mojo C++ binding: make device/usb mojom targets use STD string/vector types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move the vector converter into a private header. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/usb/mojo/type_converters.h ('K') | « third_party/WebKit/Source/modules/webusb/USB.cpp ('k') | third_party/WebKit/Source/modules/webusb/USBDevice.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webusb/USBDevice.h

diff --git a/third_party/WebKit/Source/modules/webusb/USBDevice.h b/third_party/WebKit/Source/modules/webusb/USBDevice.h

index 309caca9ec2f976e358cefa1f3641e132e2dbc82..2c427aa9c33bd2496816831304fcee872df343a3 100644

--- a/third_party/WebKit/Source/modules/webusb/USBDevice.h

+++ b/third_party/WebKit/Source/modules/webusb/USBDevice.h

@@ -101,13 +101,13 @@ private:

void asyncReleaseInterface(size_t interfaceIndex, ScriptPromiseResolver*, bool success);

void onInterfaceClaimedOrUnclaimed(bool claimed, size_t interfaceIndex);

void asyncSelectAlternateInterface(size_t interfaceIndex, size_t alternateIndex, ScriptPromiseResolver*, bool success);

- void asyncControlTransferIn(ScriptPromiseResolver*, device::usb::blink::TransferStatus, mojo::WTFArray<uint8_t>);

+ void asyncControlTransferIn(ScriptPromiseResolver*, device::usb::blink::TransferStatus, const Optional<Vector<uint8_t>>&);

void asyncControlTransferOut(unsigned, ScriptPromiseResolver*, device::usb::blink::TransferStatus);

void asyncClearHalt(ScriptPromiseResolver*, bool success);

- void asyncTransferIn(ScriptPromiseResolver*, device::usb::blink::TransferStatus, mojo::WTFArray<uint8_t>);

+ void asyncTransferIn(ScriptPromiseResolver*, device::usb::blink::TransferStatus, const Optional<Vector<uint8_t>>&);

void asyncTransferOut(unsigned, ScriptPromiseResolver*, device::usb::blink::TransferStatus);

- void asyncIsochronousTransferIn(ScriptPromiseResolver*, mojo::WTFArray<uint8_t>, mojo::WTFArray<device::usb::blink::IsochronousPacketPtr>);

- void asyncIsochronousTransferOut(ScriptPromiseResolver*, mojo::WTFArray<device::usb::blink::IsochronousPacketPtr>);

+ void asyncIsochronousTransferIn(ScriptPromiseResolver*, const Optional<Vector<uint8_t>>&, Vector<device::usb::blink::IsochronousPacketPtr>);

+ void asyncIsochronousTransferOut(ScriptPromiseResolver*, Vector<device::usb::blink::IsochronousPacketPtr>);

void asyncReset(ScriptPromiseResolver*, bool success);

void onConnectionError();