Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2269)

Unified Diff: third_party/WebKit/Source/modules/webusb/USB.cpp

Issue 2234443002: Mojo C++ binding: make device/usb mojom targets use STD string/vector types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move the vector converter into a private header. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webusb/USB.cpp
diff --git a/third_party/WebKit/Source/modules/webusb/USB.cpp b/third_party/WebKit/Source/modules/webusb/USB.cpp
index 8bb6283642f28298a87d165fdd479f2c563b09d7..8882221fd6e54b98e95f2c723043a10df17eb703 100644
--- a/third_party/WebKit/Source/modules/webusb/USB.cpp
+++ b/third_party/WebKit/Source/modules/webusb/USB.cpp
@@ -158,7 +158,7 @@ USBDevice* USB::getOrCreateDevice(usb::DeviceInfoPtr deviceInfo)
return device;
}
-void USB::onGetDevices(ScriptPromiseResolver* resolver, mojo::WTFArray<usb::DeviceInfoPtr> deviceInfos)
+void USB::onGetDevices(ScriptPromiseResolver* resolver, Vector<usb::DeviceInfoPtr> deviceInfos)
{
auto requestEntry = m_deviceManagerRequests.find(resolver);
if (requestEntry == m_deviceManagerRequests.end())
@@ -166,7 +166,7 @@ void USB::onGetDevices(ScriptPromiseResolver* resolver, mojo::WTFArray<usb::Devi
m_deviceManagerRequests.remove(requestEntry);
HeapVector<Member<USBDevice>> devices;
- for (auto& deviceInfo : deviceInfos.PassStorage())
+ for (auto& deviceInfo : deviceInfos)
devices.append(getOrCreateDevice(std::move(deviceInfo)));
resolver->resolve(devices);
m_deviceManagerRequests.remove(resolver);

Powered by Google App Engine
This is Rietveld 408576698