fix #620, infer the input files from sources

fix #620, infer the input files from sources

also simplifies build of packages used by our tests
this caused a bunch of tests that use parts to start passing

R=nweiz@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/617e3b69a61e6994bfc8eb9e2a807deda52cfd45

[Jennifer Messerly, 2016-08-11 17:47:45]

jmesserly@google.com changed reviewers:
+ nweiz@google.com, vsm@google.com

[nweiz, 2016-08-11 20:14:29]

Dart code LGTM

https://codereview.chromium.org/2234343003/diff/20001/lib/src/compiler/compil...
File lib/src/compiler/compiler.dart (right):

https://codereview.chromium.org/2234343003/diff/20001/lib/src/compiler/compil...
lib/src/compiler/compiler.dart:79: bool compilingSdk = false;
"var"?

https://codereview.chromium.org/2234343003/diff/20001/lib/src/compiler/compil...
lib/src/compiler/compiler.dart:109: var libraries = new
HashSet<LibraryElement>();
Why are you using `HashSet` explicitly?

[Jennifer Messerly, 2016-08-11 20:19:23]

Thanks! :)

https://codereview.chromium.org/2234343003/diff/20001/lib/src/compiler/compil...
File lib/src/compiler/compiler.dart (right):

https://codereview.chromium.org/2234343003/diff/20001/lib/src/compiler/compil...
lib/src/compiler/compiler.dart:79: bool compilingSdk = false;
On 2016/08/11 20:14:29, nweiz wrote:
> "var"?

Done.

https://codereview.chromium.org/2234343003/diff/20001/lib/src/compiler/compil...
lib/src/compiler/compiler.dart:109: var libraries = new
HashSet<LibraryElement>();
On 2016/08/11 20:14:29, nweiz wrote:
> Why are you using `HashSet` explicitly?

as opposed to Set? (aka LinkedHashSet)

HashSet is faster & uses less memory, which is nice when iteration order is not
being used.

[Jennifer Messerly, 2016-08-11 20:19:39]

Description was changed from

==========
fix #620, infer the input files from sources

also simplifies build of packages used by our tests
this caused a bunch of tests that use parts to start passing
==========

to

==========
fix #620, infer the input files from sources

also simplifies build of packages used by our tests
this caused a bunch of tests that use parts to start passing

R=nweiz@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/617e3b69a61e6994bfc8eb9e2a80...
==========

[Jennifer Messerly, 2016-08-11 20:19:40]

Committed patchset #3 (id:40001) manually as
617e3b69a61e6994bfc8eb9e2a807deda52cfd45 (presubmit successful).

[vsm, 2016-08-11 21:45:57]

nice!

https://codereview.chromium.org/2234343003/diff/40001/tool/build_test_pkgs.sh
File tool/build_test_pkgs.sh (right):

https://codereview.chromium.org/2234343003/diff/40001/tool/build_test_pkgs.sh...
tool/build_test_pkgs.sh:24: ./bin/dartdevc.dart $SDK  -o
gen/codegen_output/pkg/stack_trace.js \
I believe stack_trace depends on path - don't you need to pass the summary here?

[Jennifer Messerly, 2016-08-11 21:47:51]

https://codereview.chromium.org/2234343003/diff/40001/tool/build_test_pkgs.sh
File tool/build_test_pkgs.sh (right):

https://codereview.chromium.org/2234343003/diff/40001/tool/build_test_pkgs.sh...
tool/build_test_pkgs.sh:24: ./bin/dartdevc.dart $SDK  -o
gen/codegen_output/pkg/stack_trace.js \
On 2016/08/11 21:45:56, vsm wrote:
> I believe stack_trace depends on path - don't you need to pass the summary
here?

it'll just get inlined if it does. but we could save a weeeeee bit of startup
for the tests I suppose :)

[vsm, 2016-08-11 21:49:46]

On 2016/08/11 21:47:51, John Messerly wrote:
> https://codereview.chromium.org/2234343003/diff/40001/tool/build_test_pkgs.sh
> File tool/build_test_pkgs.sh (right):
> 
>
https://codereview.chromium.org/2234343003/diff/40001/tool/build_test_pkgs.sh...
> tool/build_test_pkgs.sh:24: ./bin/dartdevc.dart $SDK  -o
> gen/codegen_output/pkg/stack_trace.js \
> On 2016/08/11 21:45:56, vsm wrote:
> > I believe stack_trace depends on path - don't you need to pass the summary
> here?
> 
> it'll just get inlined if it does. but we could save a weeeeee bit of startup
> for the tests I suppose :)

Which version gets used if both are linked in by the same test?

[Jennifer Messerly, 2016-08-11 21:54:36]

On 2016/08/11 21:49:46, vsm wrote:
> On 2016/08/11 21:47:51, John Messerly wrote:
> >
https://codereview.chromium.org/2234343003/diff/40001/tool/build_test_pkgs.sh
> > File tool/build_test_pkgs.sh (right):
> > 
> >
>
https://codereview.chromium.org/2234343003/diff/40001/tool/build_test_pkgs.sh...
> > tool/build_test_pkgs.sh:24: ./bin/dartdevc.dart $SDK  -o
> > gen/codegen_output/pkg/stack_trace.js \
> > On 2016/08/11 21:45:56, vsm wrote:
> > > I believe stack_trace depends on path - don't you need to pass the summary
> > here?
> > 
> > it'll just get inlined if it does. but we could save a weeeeee bit of
startup
> > for the tests I suppose :)
> 
> Which version gets used if both are linked in by the same test?

I'm happy to fix it ... just saying it really doesn't break anything :). None of
the language tests use path.

[vsm, 2016-08-11 22:27:57]

On 2016/08/11 21:54:36, John Messerly wrote:
> On 2016/08/11 21:49:46, vsm wrote:
> > On 2016/08/11 21:47:51, John Messerly wrote:
> > >
> https://codereview.chromium.org/2234343003/diff/40001/tool/build_test_pkgs.sh
> > > File tool/build_test_pkgs.sh (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2234343003/diff/40001/tool/build_test_pkgs.sh...
> > > tool/build_test_pkgs.sh:24: ./bin/dartdevc.dart $SDK  -o
> > > gen/codegen_output/pkg/stack_trace.js \
> > > On 2016/08/11 21:45:56, vsm wrote:
> > > > I believe stack_trace depends on path - don't you need to pass the
summary
> > > here?
> > > 
> > > it'll just get inlined if it does. but we could save a weeeeee bit of
> startup
> > > for the tests I suppose :)
> > 
> > Which version gets used if both are linked in by the same test?
> 
> I'm happy to fix it ... just saying it really doesn't break anything :). None
of
> the language tests use path.

fine as is - lgtm