Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: test/worker/worker_test.dart

Issue 2234343003: fix #620, infer the input files from sources (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/worker/worker_test.dart
diff --git a/test/worker/worker_test.dart b/test/worker/worker_test.dart
index 6685acfda3490c08d6723cedb82178cfe5507d9c..5752822a2d5a3d6a3ff0fe56b703e93435b86b47 100644
--- a/test/worker/worker_test.dart
+++ b/test/worker/worker_test.dart
@@ -12,9 +12,6 @@ import 'package:bazel_worker/src/async_message_grouper.dart';
import 'package:bazel_worker/testing.dart';
import 'package:test/test.dart';
-import 'package:dev_compiler/src/compiler/compiler.dart'
- show missingPartErrorCode, unusedPartWarningCode;
-
main() {
group('Hello World', () {
final argsFile = new File('test/worker/hello_world.args').absolute;
@@ -222,7 +219,7 @@ main() {
expect(outJS.existsSync(), isTrue);
});
- test('error if part is not supplied', () {
+ test('works if part is not supplied', () {
var result = Process.runSync('dart', [
'bin/dartdevc.dart',
'compile',
@@ -232,16 +229,13 @@ main() {
outJS.path,
libraryFile.path,
]);
- expect(
- result.stdout,
- startsWith('[error] ${missingPartErrorCode.message} '
- '(test/worker/greeting.dart, line 1, col 1)'));
+ expect(result.stdout, isEmpty);
expect(result.stderr, isEmpty);
- expect(result.exitCode, 1);
- expect(outJS.existsSync(), isFalse);
+ expect(result.exitCode, 0);
+ expect(outJS.existsSync(), isTrue);
});
- test('warning if part without library is supplied', () {
+ test('part without library is silently ignored', () {
var result = Process.runSync('dart', [
'bin/dartdevc.dart',
'compile',
@@ -251,10 +245,7 @@ main() {
outJS.path,
partFile.path,
]);
- expect(
- result.stdout,
- startsWith('[warning] ${unusedPartWarningCode.message} '
- '(test/worker/greeting.dart, line 1, col 1)'));
+ expect(result.stdout, isEmpty);
expect(result.stderr, isEmpty);
expect(result.exitCode, 0);
expect(outJS.existsSync(), isTrue);
« no previous file with comments | « test/codegen_test.dart ('k') | tool/build_test_pkgs.sh » ('j') | tool/build_test_pkgs.sh » ('J')

Powered by Google App Engine
This is Rietveld 408576698