Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2234263002: Revert of [LayoutNG] Initial implementation of NGBoxIterator (Closed)

Created:
4 years, 4 months ago by samli
Modified:
4 years, 4 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [LayoutNG] Initial implementation of NGBoxIterator (patchset #4 id:60001 of https://codereview.chromium.org/2230683003/ ) Reason for revert: Fails to compile. Why was NOTRY=true used? CQ indicated an error. Original issue's description: > [LayoutNG] Initial implementation of NGBoxIterator > > NOTRY=true > BUG=635619 > > Committed: https://crrev.com/8ba5761a1d6c8f1dc7f972b75487205bfb530256 > Cr-Commit-Position: refs/heads/master@{#411263} TBR=ikilpatrick@chromium.org,cbiesinger@chromium.org,eae@chromium.org,glebl@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619 Committed: https://crrev.com/dd5c49b34b0648feae1af18ead4ebf4381f750fd Cr-Commit-Position: refs/heads/master@{#411266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -74 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 3 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box.cc View 2 chunks +9 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_box_iterator.h View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_box_iterator.cc View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
samli
Created Revert of [LayoutNG] Initial implementation of NGBoxIterator
4 years, 4 months ago (2016-08-11 04:34:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234263002/1
4 years, 4 months ago (2016-08-11 04:34:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 04:35:02 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 05:08:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd5c49b34b0648feae1af18ead4ebf4381f750fd
Cr-Commit-Position: refs/heads/master@{#411266}

Powered by Google App Engine
This is Rietveld 408576698