third_party/WebKit/Source/core/layout/ng/ng_box.h - Issue 2234263002: Revert of [LayoutNG] Initial implementation of NGBoxIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_box.h

Issue 2234263002: Revert of [LayoutNG] Initial implementation of NGBoxIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_box.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_box.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_box.h b/third_party/WebKit/Source/core/layout/ng/ng_box.h

index e24618e900a28a3371950790b84bd25c3fb6971c..e2a9e2c3468d32099c831a868dc95aff8a5c3d7a 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_box.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_box.h

@@ -5,7 +5,6 @@

#ifndef NGBox_h

#define NGBox_h

-#include "core/layout/ng/ng_box_iterator.h"

#include "core/CoreExport.h"

#include "platform/heap/Handle.h"

@@ -22,11 +21,14 @@

explicit NGBox(const LayoutObject* layoutObject)

: m_layoutObject(layoutObject) {}

- NGBoxIterator iterator() { return NGBoxIterator(m_layoutObject); }

operator bool() const { return m_layoutObject; }

NGFragment* layout(const NGConstraintSpace&);

const ComputedStyle* style() const;

+ // TODO(layout-ng): Returning a children iterator would be better here.

+ const NGBox firstChild() const;

+ const NGBox nextSibling() const;

private:

const LayoutObject* m_layoutObject;