Settings Router Refactor: Update subpage-back button to use history back sometimes.

Settings Router Refactor: Update subpage-back button to use history back sometimes.

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7400f623fad1e4ad67caf290ac7d2369bb5c56fd
Cr-Commit-Position: refs/heads/master@{#411204}

[tommycli, 2016-08-10 21:29:59]

Description was changed from

==========
Settings Router Refactor: Update subpage-back button to use history back
sometimes.

BUG=632382
==========

to

==========
Settings Router Refactor: Update subpage-back button to use history back
sometimes.

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-08-10 21:31:37]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 21:33:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-08-10 21:45:44]

tommycli@chromium.org changed reviewers:
+ dpapad@chromium.org

[tommycli, 2016-08-10 21:45:45]

dpapad: PTAL, thanks!

[dpapad, 2016-08-10 22:04:03]

LGTM, with nit question.

https://codereview.chromium.org/2234093002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/route.js (right):

https://codereview.chromium.org/2234093002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/route.js:369: var state = { previousRoutePath:
currentRoute_.path };
Can we not push the string directly instead of an object?

var previousRoutePath = currentRoute_.path;
setCurrentRoute(route, params);
window.history.pushState(previousRoutePath, '', url);

[tommycli, 2016-08-10 22:15:28]

dpapad: thanks!

https://codereview.chromium.org/2234093002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/route.js (right):

https://codereview.chromium.org/2234093002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/route.js:369: var state = { previousRoutePath:
currentRoute_.path };
On 2016/08/10 22:04:03, dpapad wrote:
> Can we not push the string directly instead of an object?
> 
> var previousRoutePath = currentRoute_.path;
> setCurrentRoute(route, params);
> window.history.pushState(previousRoutePath, '', url);

Yeah. That would be cleaner. Changed.

[tommycli, 2016-08-10 22:15:34]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 22:16:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 22:41:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 22:41:31]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[tommycli, 2016-08-10 22:49:00]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 22:50:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-08-10 23:12:30]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2016-08-10 23:12:30]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-08-10 23:12:31]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2234093002/#ps40001
(title: "fix closure compile using typecast")

[commit-bot: I haz the power, 2016-08-10 23:12:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 00:30:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-11 00:33:46]

Description was changed from

==========
Settings Router Refactor: Update subpage-back button to use history back
sometimes.

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings Router Refactor: Update subpage-back button to use history back
sometimes.

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7400f623fad1e4ad67caf290ac7d2369bb5c56fd
Cr-Commit-Position: refs/heads/master@{#411204}
==========

[commit-bot: I haz the power, 2016-08-11 00:33:47]

Patchset 3 (id:??) landed as
https://crrev.com/7400f623fad1e4ad67caf290ac7d2369bb5c56fd
Cr-Commit-Position: refs/heads/master@{#411204}