chrome/browser/resources/settings/route.js - Issue 2234093002: Settings Router Refactor: Update subpage-back button to use history back sometimes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/route.js

Issue 2234093002: Settings Router Refactor: Update subpage-back button to use history back sometimes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix closure compile using typecast Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/route.js

diff --git a/chrome/browser/resources/settings/route.js b/chrome/browser/resources/settings/route.js

index db4a0ffb92eaa9d9605a874324b68f12c8860f96..981c574e4fb8fb26a7a6f376b2bbe27e4fefe1b7 100644

--- a/chrome/browser/resources/settings/route.js

+++ b/chrome/browser/resources/settings/route.js

@@ -358,8 +358,10 @@ cr.define('settings', function() {

url += '?' + queryString;

}

+ // History serializes the state, so we don't push the actual route object.

+ var previousRoutePath = currentRoute_.path;

setCurrentRoute(route, params);

- window.history.pushState(undefined, '', url);

+ window.history.pushState(previousRoutePath, '', url);

};

window.addEventListener('popstate', function(event) {

« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_page/settings_subpage.js » ('j') | no next file with comments »