Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2234063002: Move the C bindings tests to the new location. (Closed)

Created:
4 years, 4 months ago by viettrungluu
Modified:
4 years, 4 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work791_mojo_bindings
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1397 lines) Patch
M mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/BUILD.gn View 1 chunk +30 lines, -0 lines 0 comments Download
D mojo/public/c/bindings/tests/BUILD.gn View 1 chunk +0 lines, -35 lines 0 comments Download
D mojo/public/c/bindings/tests/array_unittest.cc View 1 chunk +0 lines, -294 lines 0 comments Download
D mojo/public/c/bindings/tests/buffer_unittest.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/public/c/bindings/tests/message_unittest.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D mojo/public/c/bindings/tests/struct_unittest.cc View 1 chunk +0 lines, -365 lines 0 comments Download
D mojo/public/c/bindings/tests/testing_util.h View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/public/c/bindings/tests/union_unittest.cc View 1 chunk +0 lines, -203 lines 0 comments Download
D mojo/public/c/bindings/tests/validation_unittest.cc View 1 chunk +0 lines, -270 lines 0 comments Download
A + mojo/public/c/tests/bindings/array_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/c/tests/bindings/buffer_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/c/tests/bindings/message_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/c/tests/bindings/struct_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/c/tests/bindings/testing_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/c/tests/bindings/union_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/c/tests/bindings/validation_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Depends on Patchset:

Issue 2232833003 Patch 20001

Messages

Total messages: 4 (1 generated)
viettrungluu
(Don't mind the try failures. I think the bots are just unhappy with dependent changes ...
4 years, 4 months ago (2016-08-10 19:55:33 UTC) #1
jamesr
lgtm
4 years, 4 months ago (2016-08-10 20:25:12 UTC) #2
viettrungluu
4 years, 4 months ago (2016-08-10 20:33:13 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
843a74ced724286874ca765ff1969f369f447d3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698