Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 2232833003: Change the canonical way to include the C bindings headers to <mojo/bindings/*.h>. (Closed)

Created:
4 years, 4 months ago by viettrungluu
Modified:
4 years, 4 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work791_mojo_tests
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Change the canonical way to include the C bindings headers to <mojo/bindings/*.h>. Also: - The .c files go into mojo/public/c/lib/bindings. - The .h files formerly go into mojo/public/c/bindings/internal (they're actually included by public headers, so they can't go under lib). - I haven't moved the tests yet (to be done separately). R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/26ac597676e474ed12f6a9ffa1f725d92338f7ee

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -2273 lines) Patch
M examples/c/echo_client/echo_client.c View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/c/BUILD.gn View 3 chunks +49 lines, -0 lines 0 comments Download
D mojo/public/c/bindings/BUILD.gn View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/public/c/bindings/array.h View 1 chunk +0 lines, -135 lines 0 comments Download
D mojo/public/c/bindings/buffer.h View 1 chunk +0 lines, -48 lines 0 comments Download
D mojo/public/c/bindings/interface.h View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/public/c/bindings/lib/array.c View 1 chunk +0 lines, -254 lines 0 comments Download
D mojo/public/c/bindings/lib/buffer.c View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/public/c/bindings/lib/map.c View 1 chunk +0 lines, -36 lines 0 comments Download
D mojo/public/c/bindings/lib/message.c View 1 chunk +0 lines, -74 lines 0 comments Download
D mojo/public/c/bindings/lib/struct.c View 1 chunk +0 lines, -205 lines 0 comments Download
D mojo/public/c/bindings/lib/type_descriptor.h View 1 chunk +0 lines, -219 lines 0 comments Download
D mojo/public/c/bindings/lib/type_descriptor.c View 1 chunk +0 lines, -460 lines 0 comments Download
D mojo/public/c/bindings/lib/union.c View 1 chunk +0 lines, -160 lines 0 comments Download
D mojo/public/c/bindings/lib/util.h View 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/public/c/bindings/map.h View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/public/c/bindings/message.h View 1 chunk +0 lines, -77 lines 0 comments Download
D mojo/public/c/bindings/string.h View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/public/c/bindings/struct.h View 1 chunk +0 lines, -109 lines 0 comments Download
M mojo/public/c/bindings/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/bindings/tests/array_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/c/bindings/tests/buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/bindings/tests/message_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/bindings/tests/struct_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/public/c/bindings/tests/testing_util.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/bindings/tests/union_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/public/c/bindings/tests/validation_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
D mojo/public/c/bindings/union.h View 1 chunk +0 lines, -119 lines 0 comments Download
D mojo/public/c/bindings/validation.h View 1 chunk +0 lines, -63 lines 0 comments Download
A + mojo/public/c/include/mojo/bindings/array.h View 2 chunks +5 lines, -6 lines 0 comments Download
A + mojo/public/c/include/mojo/bindings/buffer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/c/include/mojo/bindings/interface.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/c/include/mojo/bindings/internal/type_descriptor.h View 2 chunks +6 lines, -7 lines 0 comments Download
A + mojo/public/c/include/mojo/bindings/internal/util.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + mojo/public/c/include/mojo/bindings/map.h View 2 chunks +7 lines, -8 lines 0 comments Download
A + mojo/public/c/include/mojo/bindings/message.h View 2 chunks +5 lines, -6 lines 0 comments Download
A + mojo/public/c/include/mojo/bindings/string.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + mojo/public/c/include/mojo/bindings/struct.h View 2 chunks +6 lines, -7 lines 0 comments Download
A + mojo/public/c/include/mojo/bindings/union.h View 2 chunks +6 lines, -7 lines 0 comments Download
A + mojo/public/c/include/mojo/bindings/validation.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/c/lib/bindings/array.c View 1 chunk +6 lines, -7 lines 0 comments Download
A + mojo/public/c/lib/bindings/buffer.c View 1 chunk +2 lines, -3 lines 0 comments Download
A + mojo/public/c/lib/bindings/map.c View 1 chunk +3 lines, -1 line 0 comments Download
A + mojo/public/c/lib/bindings/message.c View 1 chunk +3 lines, -4 lines 0 comments Download
A + mojo/public/c/lib/bindings/struct.c View 1 chunk +3 lines, -4 lines 0 comments Download
A + mojo/public/c/lib/bindings/type_descriptor.c View 1 chunk +7 lines, -8 lines 0 comments Download
A + mojo/public/c/lib/bindings/union.c View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 chunk +1 line, -6 lines 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/linux64/generators/c.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/mac64/generators/c.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mojom/generators/c/templates/header.tmpl.go View 1 chunk +7 lines, -8 lines 0 comments Download
M mojom/generators/c/templates/source.tmpl.go View 1 chunk +1 line, -2 lines 0 comments Download
M sdk_build/data/cpp/Makefile View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 4 months ago (2016-08-10 19:16:40 UTC) #1
jamesr
lgtm
4 years, 4 months ago (2016-08-10 20:24:09 UTC) #2
viettrungluu
4 years, 4 months ago (2016-08-10 20:32:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
26ac597676e474ed12f6a9ffa1f725d92338f7ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698