Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2233963003: Add support for constants in the new go generator. (Closed)

Created:
4 years, 4 months ago by azani
Modified:
4 years, 4 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add support for constants in the new go generator. Builtin constants (NaN, infinity, negative infinity) are not supported. BUG= Fixes #685 R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/bed778d1cd47decbeda08679159321480ce59fa2

Patch Set 1 #

Patch Set 2 : Finish implementing constants. #

Patch Set 3 : Merge branch 'master' of github.com:domokit/mojo into const #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -14 lines) Patch
M mojo/public/tools/bindings/mojom_tool/bin/linux64/generators/go.sha1 View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/mac64/generators/go.sha1 View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojom/generators/go/templates/templates.go View 1 chunk +4 lines, -0 lines 0 comments Download
M mojom/generators/go/translator/mojom_file.go View 2 chunks +11 lines, -0 lines 4 comments Download
M mojom/generators/go/translator/names.go View 1 1 chunk +26 lines, -0 lines 0 comments Download
M mojom/generators/go/translator/translator.go View 1 3 chunks +40 lines, -5 lines 0 comments Download
M mojom/generators/go/translator/types.go View 1 2 chunks +1 line, -7 lines 0 comments Download
A mojom/generators/go/translator/values.go View 1 1 chunk +74 lines, -0 lines 0 comments Download
A mojom/generators/go/translator/values_test.go View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
azani
ptal
4 years, 4 months ago (2016-08-11 21:11:28 UTC) #2
vardhan
bots are red
4 years, 4 months ago (2016-08-11 21:13:16 UTC) #3
azani
it was just a trivial merge conflict. ptal
4 years, 4 months ago (2016-08-11 21:20:12 UTC) #4
vardhan
lgtm w/ nits https://codereview.chromium.org/2233963003/diff/40001/mojom/generators/go/translator/mojom_file.go File mojom/generators/go/translator/mojom_file.go (right): https://codereview.chromium.org/2233963003/diff/40001/mojom/generators/go/translator/mojom_file.go#newcode21 mojom/generators/go/translator/mojom_file.go:21: Constants []*ConstantTemplate tabs https://codereview.chromium.org/2233963003/diff/40001/mojom/generators/go/translator/mojom_file.go#newcode228 mojom/generators/go/translator/mojom_file.go:228: empty ...
4 years, 4 months ago (2016-08-15 22:51:59 UTC) #6
azani
https://codereview.chromium.org/2233963003/diff/40001/mojom/generators/go/translator/mojom_file.go File mojom/generators/go/translator/mojom_file.go (right): https://codereview.chromium.org/2233963003/diff/40001/mojom/generators/go/translator/mojom_file.go#newcode21 mojom/generators/go/translator/mojom_file.go:21: Constants []*ConstantTemplate On 2016/08/15 22:51:59, vardhan wrote: > tabs ...
4 years, 4 months ago (2016-08-15 23:49:39 UTC) #7
azani
4 years, 4 months ago (2016-08-16 00:00:09 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
bed778d1cd47decbeda08679159321480ce59fa2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698