Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: mojom/generators/go/translator/types.go

Issue 2233963003: Add support for constants in the new go generator. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Merge branch 'master' of github.com:domokit/mojo into const Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojom/generators/go/translator/types.go
diff --git a/mojom/generators/go/translator/types.go b/mojom/generators/go/translator/types.go
index af2682acdd6aa3a61d33e8dbc26645ad7e0bc995..43e6ef3dfa0b0427227fea59e5f1edf69a0aa6a5 100644
--- a/mojom/generators/go/translator/types.go
+++ b/mojom/generators/go/translator/types.go
@@ -6,7 +6,6 @@ package translator
import (
"fmt"
- "path/filepath"
"mojom/generated/mojom_types"
)
@@ -132,12 +131,7 @@ func (t *translator) translateTypeReference(typeRef mojom_types.TypeReference) (
srcFileInfo := userDefinedTypeDeclData(userDefinedType).SourceFileInfo
if srcFileInfo != nil && srcFileInfo.FileName != t.currentFileName {
pkgName := fileNameToPackageName(srcFileInfo.FileName)
- pkgPath, err := filepath.Rel(t.Config.SrcRootPath(), srcFileInfo.FileName)
- if err != nil {
- panic(err.Error())
- }
- pkgPath = pkgPath[:len(pkgPath)-len(filepath.Ext(pkgPath))]
- t.imports[pkgName] = pkgPath
+ t.importMojomFile(srcFileInfo.FileName)
typeName = fmt.Sprintf("%s.%s", pkgName, typeName)
}

Powered by Google App Engine
This is Rietveld 408576698