Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java

Issue 22339023: Fix for issue 11497- liberalize warnings about bad overrides (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status files Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
index 90d9546ef77f32041b57643080706315b0c55618..370aa1718ac1790aff522906af7848b426a2f1f7 100644
--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
@@ -1714,58 +1714,6 @@ public class CompileTimeErrorCodeTest extends ResolverTestCase {
// no verify() call, "B" is not resolved
}
- public void test_invalidOverrideNamed_fewerNamedParameters() throws Exception {
- Source source = addSource(createSource(//
- "class A {",
- " m({a, b}) {}",
- "}",
- "class B extends A {",
- " m({a}) {}",
- "}"));
- resolve(source);
- assertErrors(CompileTimeErrorCode.INVALID_OVERRIDE_NAMED);
- verify(source);
- }
-
- public void test_invalidOverrideNamed_missingNamedParameter() throws Exception {
- Source source = addSource(createSource(//
- "class A {",
- " m({a, b}) {}",
- "}",
- "class B extends A {",
- " m({a, c}) {}",
- "}"));
- resolve(source);
- assertErrors(CompileTimeErrorCode.INVALID_OVERRIDE_NAMED);
- verify(source);
- }
-
- public void test_invalidOverridePositional() throws Exception {
- Source source = addSource(createSource(//
- "class A {",
- " m([a, b]) {}",
- "}",
- "class B extends A {",
- " m([a]) {}",
- "}"));
- resolve(source);
- assertErrors(CompileTimeErrorCode.INVALID_OVERRIDE_POSITIONAL);
- verify(source);
- }
-
- public void test_invalidOverrideRequired() throws Exception {
- Source source = addSource(createSource(//
- "class A {",
- " m(a) {}",
- "}",
- "class B extends A {",
- " m(a, b) {}",
- "}"));
- resolve(source);
- assertErrors(CompileTimeErrorCode.INVALID_OVERRIDE_REQUIRED);
- verify(source);
- }
-
public void test_invalidReferenceToThis_factoryConstructor() throws Exception {
Source source = addSource(createSource(//
"class A {",

Powered by Google App Engine
This is Rietveld 408576698