editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java - Issue 22339023: Fix for issue 11497- liberalize warnings about bad overrides

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

Issue 22339023: Fix for issue 11497- liberalize warnings about bad overrides (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Update status files Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java ('k') | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java » ('j') | tests/co19/co19-analyzer.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

index 4392508739e7cea7dab4ac6f3abf317ab76a004e..f458f0b53e35756b78dd21fd3f6b89f74ffa331d 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

@@ -1146,7 +1146,7 @@ public class ErrorVerifier extends RecursiveASTVisitor<Void> {

// CTEC.INVALID_OVERRIDE_REQUIRED, CTEC.INVALID_OVERRIDE_POSITIONAL and CTEC.INVALID_OVERRIDE_NAMED

if (overridingNormalPT.length != overriddenNormalPT.length) {

errorReporter.reportError(

- CompileTimeErrorCode.INVALID_OVERRIDE_REQUIRED,

+ StaticWarningCode.INVALID_OVERRIDE_REQUIRED,

errorNameTarget,

overriddenNormalPT.length,

overriddenExecutable.getEnclosingElement().getDisplayName());

@@ -1154,7 +1154,7 @@ public class ErrorVerifier extends RecursiveASTVisitor<Void> {

}

if (overridingPositionalPT.length < overriddenPositionalPT.length) {

errorReporter.reportError(

- CompileTimeErrorCode.INVALID_OVERRIDE_POSITIONAL,

+ StaticWarningCode.INVALID_OVERRIDE_POSITIONAL,

errorNameTarget,

overriddenPositionalPT.length,

overriddenExecutable.getEnclosingElement().getDisplayName());

@@ -1170,7 +1170,7 @@ public class ErrorVerifier extends RecursiveASTVisitor<Void> {

// The overridden method expected the overriding method to have overridingParamName,

// but it does not.

errorReporter.reportError(

- CompileTimeErrorCode.INVALID_OVERRIDE_NAMED,

+ StaticWarningCode.INVALID_OVERRIDE_NAMED,

errorNameTarget,

overriddenParamName,

overriddenExecutable.getEnclosingElement().getDisplayName());