Docserver api dependencies no longer crash cron

chrome/common/extensions/docs/server2/api_data_source.py

Index: chrome/common/extensions/docs/server2/api_data_source.py
diff --git a/chrome/common/extensions/docs/server2/api_data_source.py b/chrome/common/extensions/docs/server2/api_data_source.py
index 6211cdb4c7581749d3a066d36a892d1064c1d339..d01794268e2215ece577e7f844a94d9915e7a47c 100644
--- a/chrome/common/extensions/docs/server2/api_data_source.py
+++ b/chrome/common/extensions/docs/server2/api_data_source.py
@@ -223,15 +223,20 @@ class _JSCModel(object):
     permissions_content = []
     manifest_content = []
 
-    for dependency in dependencies:
+    def categorize_dependency(dependency):
       context, name = dependency.split(':', 1)
       if context == 'permission':
         permissions_content.append(make_code_node('"%s"' % name))
       elif context == 'manifest':
         manifest_content.append(make_code_node('"%s": {...}' % name))
-      else:
-        raise ValueError('Unrecognized dependency for %s: %s'
-                         % (self._namespace.name, context))
+      elif context is not None:

[not at google - send to devlin, 2013/08/06 20:25:58]

make it == 'app' so we continue to catch errors.

[jshumway, 2013/08/06 21:01:32]

Ah, okay. (set it to 'api')

+        transitive_dependencies = (
+            self._api_features.get(context, {}).get('dependencies', []))
+        for transitive_dependency in transitive_dependencies:
+          categorize_dependency(transitive_dependency)
+
+    for dependency in dependencies:
+      categorize_dependency(dependency)
 
     dependency_rows = []
     if permissions_content: