Docserver api dependencies no longer crash cron

chrome/common/extensions/docs/server2/api_data_source.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 import logging
 import os
 from collections import defaultdict, Mapping
 
 from branch_utility import BranchUtility
@@ skipping 205 matching lines @@
     dependencies = feature.get('dependencies')
     if dependencies is None:
       return []
 
     def make_code_node(text):
       return { 'class': 'code', 'text': text }
 
     permissions_content = []
     manifest_content = []
 
-    for dependency in dependencies:
+    def categorize_dependency(dependency):
       context, name = dependency.split(':', 1)
       if context == 'permission':
         permissions_content.append(make_code_node('"%s"' % name))
       elif context == 'manifest':
         manifest_content.append(make_code_node('"%s": {...}' % name))
-      else:
-        raise ValueError('Unrecognized dependency for %s: %s'
-                         % (self._namespace.name, context))
+      elif context is not None:

[not at google - send to devlin, 2013/08/06 20:25:58]

make it == 'app' so we continue to catch errors.

[jshumway, 2013/08/06 21:01:32]

Ah, okay. (set it to 'api')

+        transitive_dependencies = (
+            self._api_features.get(context, {}).get('dependencies', []))
+        for transitive_dependency in transitive_dependencies:
+          categorize_dependency(transitive_dependency)
+
+    for dependency in dependencies:
+      categorize_dependency(dependency)
 
     dependency_rows = []
     if permissions_content:
       dependency_rows.append({
         'title': 'Permissions',
         'content': permissions_content
       })
     if manifest_content:
       dependency_rows.append({
         'title': 'Manifest',
@@ skipping 370 matching lines @@
     if self._disable_refs:
       cache, ext = (
           (self._idl_cache_no_refs, '.idl') if (unix_name in idl_names) else
           (self._json_cache_no_refs, '.json'))
     else:
       cache, ext = ((self._idl_cache, '.idl') if (unix_name in idl_names) else
                     (self._json_cache, '.json'))
     return self._GenerateHandlebarContext(
         cache.GetFromFile('%s/%s%s' % (self._base_path, unix_name, ext)),
         path)