Accept empty username as sync username in IsSyncAccountCredential

Accept empty username as sync username in IsSyncAccountCredential

IsSyncAccountCredential is used by SyncCredentialsFilter::ShouldSave to
determine whether a credential to be saved is in fact the user's sync
credential. Chrome won't offer to save the sync credential for security
concerns [1]. Under some circumstances, Chrome might not be able to detect the
username when the user types in the Google credential (which might potentially
be the sync credential). In those cases the username is empty and so far Chrome
would not recognise such credential as the sync credential and saved the
password.

To prevent that, this CL modifies IsSyncAccountCredential to treat an empty
username as equal to the sync username.

[1] https://www.chromium.org/Home/chromium-security/security-faq#TOC-Why-doesn-t-the-Password-Manager-save-my-Google-password-if-I-am-using-Chrome-Sync-

R=dvadym@chromium.org
BUG=636292
Committed: https://crrev.com/7a1668cdc5a4eb44fadd2f947559a03c441a96b5
Cr-Commit-Position: refs/heads/master@{#411035}

[vabr (Chromium), 2016-08-10 13:02:04]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 13:02:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dvadym, 2016-08-10 13:12:09]

On 2016/08/10 13:02:18, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

LGTM

[vabr (Chromium), 2016-08-10 13:14:04]

The CQ bit was unchecked by vabr@chromium.org

[vabr (Chromium), 2016-08-10 13:14:08]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-08-10 13:14:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 14:11:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-10 14:12:59]

Description was changed from

==========
Accept empty username as sync username in IsSyncAccountCredential

IsSyncAccountCredential is used by SyncCredentialsFilter::ShouldSave to
determine whether a credential to be saved is in fact the user's sync
credential. Chrome won't offer to save the sync credential for security
concerns [1]. Under some circumstances, Chrome might not be able to detect the
username when the user types in the Google credential (which might potentially
be the sync credential). In those cases the username is empty and so far Chrome
would not recognise such credential as the sync credential and saved the
password.

To prevent that, this CL modifies IsSyncAccountCredential to treat an empty
username as equal to the sync username.

[1]
https://www.chromium.org/Home/chromium-security/security-faq#TOC-Why-doesn-t-...

R=dvadym@chromium.org
BUG=636292
==========

to

==========
Accept empty username as sync username in IsSyncAccountCredential

IsSyncAccountCredential is used by SyncCredentialsFilter::ShouldSave to
determine whether a credential to be saved is in fact the user's sync
credential. Chrome won't offer to save the sync credential for security
concerns [1]. Under some circumstances, Chrome might not be able to detect the
username when the user types in the Google credential (which might potentially
be the sync credential). In those cases the username is empty and so far Chrome
would not recognise such credential as the sync credential and saved the
password.

To prevent that, this CL modifies IsSyncAccountCredential to treat an empty
username as equal to the sync username.

[1]
https://www.chromium.org/Home/chromium-security/security-faq#TOC-Why-doesn-t-...

R=dvadym@chromium.org
BUG=636292

Committed: https://crrev.com/7a1668cdc5a4eb44fadd2f947559a03c441a96b5
Cr-Commit-Position: refs/heads/master@{#411035}
==========

[commit-bot: I haz the power, 2016-08-10 14:13:00]

Patchset 1 (id:??) landed as
https://crrev.com/7a1668cdc5a4eb44fadd2f947559a03c441a96b5
Cr-Commit-Position: refs/heads/master@{#411035}