components/password_manager/sync/browser/password_sync_util_unittest.cc - Issue 2233833002: Accept empty username as sync username in IsSyncAccountCredential

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/sync/browser/password_sync_util_unittest.cc

Issue 2233833002: Accept empty username as sync username in IsSyncAccountCredential (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/password_manager/sync/browser/password_sync_util_unittest.cc

diff --git a/components/password_manager/sync/browser/password_sync_util_unittest.cc b/components/password_manager/sync/browser/password_sync_util_unittest.cc

index d1bfc448677c59ff98d5f943acd83dec181d026b..5c21a83ebdfdcc41943a1543356995fe20392429 100644

--- a/components/password_manager/sync/browser/password_sync_util_unittest.cc

+++ b/components/password_manager/sync/browser/password_sync_util_unittest.cc

@@ -66,6 +66,8 @@ TEST_F(PasswordSyncUtilTest, IsSyncAccountCredential) {

false},

{SimpleNonGaiaForm("sync_user@example.org"), "sync_user@example.org",

false},

+ {SimpleGaiaForm(""), "sync_user@example.org", true},

+ {SimpleNonGaiaForm(""), "sync_user@example.org", false},

};

for (size_t i = 0; i < arraysize(kTestCases); ++i) {

« no previous file with comments | « components/password_manager/sync/browser/password_sync_util.cc ('k') | no next file » | no next file with comments »