[turbofan] Fix CheckedInt32Mod lowering.

[turbofan] Fix CheckedInt32Mod lowering.

We now deopt when the lhs of a mod is negative and the rhs is 1 too (previously, we erroneusly returned 0 instead of -0).

BUG=v8:5278
R=bmeurer@chromium.org

Committed: https://crrev.com/9e14155da90ca55199f25ab81a6a6fba03a8d800
Cr-Commit-Position: refs/heads/master@{#38525}

[epertoso, 2016-08-10 08:49:57]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 08:49:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-08-10 08:51:07]

LGTM nce comments addressed.

https://codereview.chromium.org/2233713002/diff/1/test/mjsunit/compiler/regre...
File test/mjsunit/compiler/regress-5278.js (right):

https://codereview.chromium.org/2233713002/diff/1/test/mjsunit/compiler/regre...
test/mjsunit/compiler/regress-5278.js:5: // Flags: --allow-natives-syntax
--turbo
Don't add --turbo here.

https://codereview.chromium.org/2233713002/diff/1/test/mjsunit/compiler/regre...
test/mjsunit/compiler/regress-5278.js:7: (function CheckedInt32Mod() {
Nit: Just use global scope here.

[epertoso, 2016-08-10 08:53:33]

https://codereview.chromium.org/2233713002/diff/1/test/mjsunit/compiler/regre...
File test/mjsunit/compiler/regress-5278.js (right):

https://codereview.chromium.org/2233713002/diff/1/test/mjsunit/compiler/regre...
test/mjsunit/compiler/regress-5278.js:5: // Flags: --allow-natives-syntax
--turbo
On 2016/08/10 08:51:07, Benedikt Meurer wrote:
> Don't add --turbo here.

Done.

https://codereview.chromium.org/2233713002/diff/1/test/mjsunit/compiler/regre...
test/mjsunit/compiler/regress-5278.js:7: (function CheckedInt32Mod() {
On 2016/08/10 08:51:07, Benedikt Meurer wrote:
> Nit: Just use global scope here.

Done.

[epertoso, 2016-08-10 08:53:40]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-08-10 08:53:41]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2233713002/#ps20001
(title: "Update.")

[commit-bot: I haz the power, 2016-08-10 08:53:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 09:24:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-10 09:25:08]

Description was changed from

==========
[turbofan] Fix CheckedInt32Mod lowering.

We now deopt when the lhs of a mod is negative and the rhs is 1 too (previously,
we erroneusly returned 0 instead of -0).

BUG=v8:5278
R=bmeurer@chromium.org
==========

to

==========
[turbofan] Fix CheckedInt32Mod lowering.

We now deopt when the lhs of a mod is negative and the rhs is 1 too (previously,
we erroneusly returned 0 instead of -0).

BUG=v8:5278
R=bmeurer@chromium.org

Committed: https://crrev.com/9e14155da90ca55199f25ab81a6a6fba03a8d800
Cr-Commit-Position: refs/heads/master@{#38525}
==========

[commit-bot: I haz the power, 2016-08-10 09:25:09]

Patchset 2 (id:??) landed as
https://crrev.com/9e14155da90ca55199f25ab81a6a6fba03a8d800
Cr-Commit-Position: refs/heads/master@{#38525}