[turbofan] Fix CheckedInt32Mod lowering.

src/compiler/effect-control-linearizer.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/effect-control-linearizer.h"
 
 #include "src/code-factory.h"
 #include "src/compiler/access-builder.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/linkage.h"
@@ skipping 1289 matching lines @@
       common()->DeoptimizeUnless(DeoptimizeReason::kLostPrecision), check,
       frame_state, effect, control);
 
   return ValueEffectControl(value, effect, control);
 }
 
 EffectControlLinearizer::ValueEffectControl
 EffectControlLinearizer::LowerCheckedInt32Mod(Node* node, Node* frame_state,
                                               Node* effect, Node* control) {
   Node* zero = jsgraph()->Int32Constant(0);
+  Node* one = jsgraph()->Int32Constant(1);
   Node* minusone = jsgraph()->Int32Constant(-1);
-  Node* minint = jsgraph()->Int32Constant(std::numeric_limits<int32_t>::min());
 
   // General case for signed integer modulus, with optimization for (unknown)
   // power of 2 right hand side.
   //
-  //   if 0 < rhs then
+  //   if 1 < rhs then
   //     msk = rhs - 1
   //     if rhs & msk == 0 then
   //       if lhs < 0 then
   //         -(-lhs & msk)
   //       else
   //         lhs & msk
   //     else
   //       lhs % rhs
   //   else
   //     if rhs < -1 then
   //       lhs % rhs
   //     else
   //       deopt if rhs == 0
-  //       deopt if lhs == minint
+  //       deopt if lhs < 0
   //       zero
   //
   Node* lhs = node->InputAt(0);
   Node* rhs = node->InputAt(1);
 
-  // Check if {rhs} is strictly positive.
-  Node* check0 = graph()->NewNode(machine()->Int32LessThan(), zero, rhs);
+  // Check if {rhs} is strictly greater than one.
+  Node* check0 = graph()->NewNode(machine()->Int32LessThan(), one, rhs);
   Node* branch0 =
       graph()->NewNode(common()->Branch(BranchHint::kTrue), check0, control);
 
   Node* if_true0 = graph()->NewNode(common()->IfTrue(), branch0);
   Node* etrue0 = effect;
   Node* vtrue0;
   {
     Node* msk = graph()->NewNode(machine()->Int32Add(), rhs, minusone);
 
     // Check if {rhs} minus one is a valid mask.
@@ skipping 55 matching lines @@
     Node* if_false1 = graph()->NewNode(common()->IfFalse(), branch1);
     Node* efalse1 = efalse0;
     Node* vfalse1;
     {
       // Ensure that {rhs} is not zero.
       Node* check2 = graph()->NewNode(machine()->Word32Equal(), rhs, zero);
       if_false1 = efalse1 = graph()->NewNode(
           common()->DeoptimizeIf(DeoptimizeReason::kDivisionByZero), check2,
           frame_state, efalse1, if_false1);
 
-      // Now we know that {rhs} is -1, so make sure {lhs} is not kMinInt, as
-      // we would otherwise have to return -0.
-      Node* check3 = graph()->NewNode(machine()->Word32Equal(), lhs, minint);
+      // Now we know that {rhs} is -1, so make sure {lhs} is >= 0, as we would
+      // otherwise have to return -0.
+      Node* check3 = graph()->NewNode(machine()->Int32LessThan(), lhs, zero);
       if_false1 = efalse1 =
           graph()->NewNode(common()->DeoptimizeIf(DeoptimizeReason::kMinusZero),
                            check3, frame_state, efalse1, if_false1);
 
       // The remainder is zero.
       vfalse1 = zero;
     }
 
     if_false0 = graph()->NewNode(common()->Merge(2), if_true1, if_false1);
     efalse0 =
@@ skipping 1863 matching lines @@
         isolate(), graph()->zone(), callable.descriptor(), 0, flags,
         Operator::kNoThrow);
     to_number_operator_.set(common()->Call(desc));
   }
   return to_number_operator_.get();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8