Use the runtime flag and remove '-webkit-' prefix for CSS3 text-indent.

Use the runtime flag and remove '-webkit-' prefix for CSS3 text-indent.

The each-line value of CSS3TEXT text-indent is enabled when the run time
flag is enabled.

Tests using 'ex' unit are failed in Linux, Mac because of other issue.
Refer to https://code.google.com/p/chromium/issues/detail?id=31488.

BUG=269277
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156608

[Julien - ping for review, 2013-08-21 01:50:07]

https://codereview.chromium.org/22336008/diff/1/Source/core/css/resolver/Styl...
File Source/core/css/resolver/StyleBuilderCustom.cpp (right):

https://codereview.chromium.org/22336008/diff/1/Source/core/css/resolver/Styl...
Source/core/css/resolver/StyleBuilderCustom.cpp:525: if
(RuntimeEnabledFeatures::css3TextEnabled())
Again shouldn't be needed as we block each-line at parse time.

https://codereview.chromium.org/22336008/diff/1/Source/core/css/resolver/Styl...
Source/core/css/resolver/StyleBuilderCustom.cpp:544: if
(!RuntimeEnabledFeatures::css3TextEnabled())
You reject CSS 3 Text at parse time if the flag is off so this should be
unneeded, replacing it with an ASSERT would make sense though.

https://codereview.chromium.org/22336008/diff/1/Source/core/rendering/RenderB...
File Source/core/rendering/RenderBlockLineLayout.cpp (right):

https://codereview.chromium.org/22336008/diff/1/Source/core/rendering/RenderB...
Source/core/rendering/RenderBlockLineLayout.cpp:962: if
(RuntimeEnabledFeatures::css3TextEnabled() && isAfterHardLineBreak &&
style->textIndentLine() == TextIndentEachLine)
This is unneeded. If CSS3 Text is not enabled, we shouldn't allow
TextIndexEachLine as a value and this should be dead code.

[jaehun, 2013-08-21 05:51:02]

Thanks for review. Please, review new one.

https://codereview.chromium.org/22336008/diff/1/Source/core/css/resolver/Styl...
File Source/core/css/resolver/StyleBuilderCustom.cpp (right):

https://codereview.chromium.org/22336008/diff/1/Source/core/css/resolver/Styl...
Source/core/css/resolver/StyleBuilderCustom.cpp:525: if
(RuntimeEnabledFeatures::css3TextEnabled())
On 2013/08/21 01:50:08, Julien Chaffraix wrote:
> Again shouldn't be needed as we block each-line at parse time.

Done.

https://codereview.chromium.org/22336008/diff/1/Source/core/css/resolver/Styl...
Source/core/css/resolver/StyleBuilderCustom.cpp:544: if
(!RuntimeEnabledFeatures::css3TextEnabled())
On 2013/08/21 01:50:08, Julien Chaffraix wrote:
> You reject CSS 3 Text at parse time if the flag is off so this should be
> unneeded, replacing it with an ASSERT would make sense though.

Removed.

https://codereview.chromium.org/22336008/diff/1/Source/core/rendering/RenderB...
File Source/core/rendering/RenderBlockLineLayout.cpp (right):

https://codereview.chromium.org/22336008/diff/1/Source/core/rendering/RenderB...
Source/core/rendering/RenderBlockLineLayout.cpp:962: if
(RuntimeEnabledFeatures::css3TextEnabled() && isAfterHardLineBreak &&
style->textIndentLine() == TextIndentEachLine)
On 2013/08/21 01:50:08, Julien Chaffraix wrote:
> This is unneeded. If CSS3 Text is not enabled, we shouldn't allow
> TextIndexEachLine as a value and this should be dead code.

Done.

[Julien - ping for review, 2013-08-21 23:54:49]

lgtm

https://codereview.chromium.org/22336008/diff/6001/LayoutTests/TestExpectations
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/22336008/diff/6001/LayoutTests/TestExpectatio...
LayoutTests/TestExpectations:80: crbug.com/31448 [ Linux Mac ]
fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html
[ Failure ]
Typo, the right bug is crbug.com/31488

https://codereview.chromium.org/22336008/diff/6001/Source/core/css/CSSCompute...
File Source/core/css/CSSComputedStyleDeclaration.cpp (right):

https://codereview.chromium.org/22336008/diff/6001/Source/core/css/CSSCompute...
Source/core/css/CSSComputedStyleDeclaration.cpp:2256: if
(RuntimeEnabledFeatures::css3TextEnabled() && style->textIndentLine() ==
TextIndentEachLine) {
Let's keep in mind that we would like to test this once we have a test suite for
stable behavior (which should be today or tomorrow).

https://codereview.chromium.org/22336008/diff/6001/Source/core/css/resolver/S...
File Source/core/css/resolver/StyleBuilderCustom.cpp (left):

https://codereview.chromium.org/22336008/diff/6001/Source/core/css/resolver/S...
Source/core/css/resolver/StyleBuilderCustom.cpp:548: ASSERT(valueList->length()
<= 2);
This ASSERT is still valid AFAICT so we should keep it.

Let's also add the following assert to catch any misuse:

ASSERT(RuntimeEnabledFeatures::css3TextEnabled())

[jaehun, 2013-08-22 02:04:39]

Thx. I upload a new patch.

https://codereview.chromium.org/22336008/diff/6001/LayoutTests/TestExpectations
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/22336008/diff/6001/LayoutTests/TestExpectatio...
LayoutTests/TestExpectations:80: crbug.com/31448 [ Linux Mac ]
fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html
[ Failure ]
On 2013/08/21 23:54:50, Julien Chaffraix wrote:
> Typo, the right bug is crbug.com/31488

Oops, Fixed.

https://codereview.chromium.org/22336008/diff/6001/Source/core/css/resolver/S...
File Source/core/css/resolver/StyleBuilderCustom.cpp (left):

https://codereview.chromium.org/22336008/diff/6001/Source/core/css/resolver/S...
Source/core/css/resolver/StyleBuilderCustom.cpp:548: ASSERT(valueList->length()
<= 2);
On 2013/08/21 23:54:50, Julien Chaffraix wrote:
> This ASSERT is still valid AFAICT so we should keep it.
Umm... I agree. I'll recover ASSERT.

> 
> Let's also add the following assert to catch any misuse:
> 
> ASSERT(RuntimeEnabledFeatures::css3TextEnabled())

[Julien - ping for review, 2013-08-22 22:54:44]

lgtm

[commit-bot: I haz the power, 2013-08-22 22:55:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ljaehun.lim@samsung.com/22336008/21001

[commit-bot: I haz the power, 2013-08-23 01:28:35]

Change committed as 156608