Source/core/css/CSSComputedStyleDeclaration.cpp - Issue 22336008: Use the runtime flag and remove '-webkit-' prefix for CSS3 text-indent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 22336008: Use the runtime flag and remove '-webkit-' prefix for CSS3 text-indent. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/platform/win/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt ('k') | Source/core/css/CSSParser-in.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/Source/core/css/CSSComputedStyleDeclaration.cpp b/Source/core/css/CSSComputedStyleDeclaration.cpp

index 44cb8a86268a4cd5800bd77810462f24119c95ff..4e8f1dc3a0d80bdec23a66a427ce2b3189487a77 100644

--- a/Source/core/css/CSSComputedStyleDeclaration.cpp

+++ b/Source/core/css/CSSComputedStyleDeclaration.cpp

@@ -2242,14 +2242,12 @@ PassRefPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValue(CSSPropert

}

case CSSPropertyTextIndent: {

RefPtr<CSSValue> textIndent = zoomAdjustedPixelValueForLength(style->textIndent(), style.get());

-#if ENABLE(CSS3_TEXT)

- if (style->textIndentLine() == TextIndentEachLine) {

+ if (RuntimeEnabledFeatures::css3TextEnabled() && style->textIndentLine() == TextIndentEachLine) {

RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();

list->append(textIndent.release());

- list->append(cssValuePool().createIdentifierValue(CSSValueWebkitEachLine));

+ list->append(cssValuePool().createIdentifierValue(CSSValueEachLine));

return list.release();

}

-#endif

return textIndent.release();

}

case CSSPropertyTextShadow: