DescriptionRevert of Fix setComposingText with empty text when newCursorPosition != 1 (patchset #16 id:300001 of https://codereview.chromium.org/2020973002/ )
Reason for revert:
This caused a regression (https://crbug.com/633840), and there doesn't seem to be an easy fix.
Original issue's description:
> Fix setComposingText with empty text when newCursorPosition != 1
>
> setComposingText("", newCursorPosition) doesn't work fine when
> newCursorPosition != 1. It should behave the same as
> commitText("", newCursorPosition), because when the text is empty,
> commitText will call InputMethodController::setComposition, which is
> exactly the same as setComposingText().
>
> BUG=570920
>
> Committed: https://crrev.com/f22aa57c3e53c94264b0a0ac6e556ac03b89f372
> Cr-Commit-Position: refs/heads/master@{#409169}
TBR=yosin@chromium.org,aelias@chromium.org,esprehn@chromium.org,tkent@chromium.org,yabinh@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=570920
Committed: https://crrev.com/eb158294ffe22a859edd49038e5248dbb7895ca8
Cr-Commit-Position: refs/heads/master@{#410946}
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|