Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2233573002: Revert of Fix setComposingText with empty text when newCursorPosition != 1 (Closed)

Created:
4 years, 4 months ago by Changwan Ryu
Modified:
4 years, 4 months ago
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix setComposingText with empty text when newCursorPosition != 1 (patchset #16 id:300001 of https://codereview.chromium.org/2020973002/ ) Reason for revert: This caused a regression (https://crbug.com/633840), and there doesn't seem to be an easy fix. Original issue's description: > Fix setComposingText with empty text when newCursorPosition != 1 > > setComposingText("", newCursorPosition) doesn't work fine when > newCursorPosition != 1. It should behave the same as > commitText("", newCursorPosition), because when the text is empty, > commitText will call InputMethodController::setComposition, which is > exactly the same as setComposingText(). > > BUG=570920 > > Committed: https://crrev.com/f22aa57c3e53c94264b0a0ac6e556ac03b89f372 > Cr-Commit-Position: refs/heads/master@{#409169} TBR=yosin@chromium.org,aelias@chromium.org,esprehn@chromium.org,tkent@chromium.org,yabinh@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=570920 Committed: https://crrev.com/eb158294ffe22a859edd49038e5248dbb7895ca8 Cr-Commit-Position: refs/heads/master@{#410946}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -103 lines) Patch
M components/test_runner/text_input_controller.cc View 1 chunk +6 lines, -10 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 2 chunks +3 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 4 chunks +29 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Changwan Ryu
Created Revert of Fix setComposingText with empty text when newCursorPosition != 1
4 years, 4 months ago (2016-08-10 00:54:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233573002/1
4 years, 4 months ago (2016-08-10 00:55:32 UTC) #3
tkent
lgtm
4 years, 4 months ago (2016-08-10 01:02:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 03:36:07 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 03:38:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb158294ffe22a859edd49038e5248dbb7895ca8
Cr-Commit-Position: refs/heads/master@{#410946}

Powered by Google App Engine
This is Rietveld 408576698