Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 2233573002: Revert of Fix setComposingText with empty text when newCursorPosition != 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
index 9bec9495b9bab03f63130f56ca0db8cb96d42f2f..3e5654fed374297f18683dd05f99a107d3510dff 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
@@ -139,6 +139,9 @@
assertTextsAroundCursor("he", "", "llo");
}
+ // When newCursorPosition != 1, setComposingText doesn't work for ReplicaInputConnection
+ // because there is a bug in BaseInputConnection.
+ @CommandLineFlags.Add("enable-features=ImeThread")
@SmallTest
@Feature({"TextInput", "Main"})
public void testSetComposingTextForDifferentnewCursorPositions() throws Throwable {
@@ -183,24 +186,6 @@
// Cursor exceeds the right boundary.
setComposingText("efgh", 100);
waitAndVerifyUpdateSelection(10, 8, 8, 2, 6);
- }
-
- @SmallTest
- @Feature({"TextInput", "Main"})
- public void testSetComposingTextWithEmptyText() throws Throwable {
- commitText("hello", 1);
- waitAndVerifyUpdateSelection(0, 5, 5, -1, -1);
-
- setComposingText("AB", 1);
- waitAndVerifyUpdateSelection(1, 7, 7, 5, 7);
-
- // With previous composition.
- setComposingText("", -3);
- waitAndVerifyUpdateSelection(2, 2, 2, -1, -1);
-
- // Without previous composition.
- setComposingText("", 3);
- waitAndVerifyUpdateSelection(3, 4, 4, -1, -1);
}
@SmallTest
« no previous file with comments | « components/test_runner/text_input_controller.cc ('k') | third_party/WebKit/Source/core/editing/InputMethodController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698