SW: Propagate errors/exceptions from service worker to browser

SW: Propagate errors/exceptions from service worker to browser

To propagate errors/exceptions from service worker to browser, this implements
WebServiceWorkerContextClient::reportException and adds new IPC message.


BUG=359423
TEST=manual (throw an exception in service-worker script)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262606

[nhiroki, 2014-04-03 10:22:59]

Hi, can you review this? Thanks!

[kinuko, 2014-04-03 15:42:40]

lgtm

[kinuko, 2014-04-03 15:43:46]

+tsepez@ for IPC message review (Tom, can you?)

[nhiroki, 2014-04-04 06:24:24]

(+jln@, -tsepez@)

Hi Julien, can you review the IPC message? (Tom seems to be ooo now.)

[jln (very slow on Chromium), 2014-04-07 23:28:28]

On 2014/04/04 06:24:24, nhiroki wrote:
> (+jln@, -tsepez@)
> 
> Hi Julien, can you review the IPC message? (Tom seems to be ooo now.)

Sorry, still going through my backlog. Tom is back, so sending back his way.
Tom, re-assign to me if you have a large backlog.

[Tom Sepez, 2014-04-07 23:56:18]

https://codereview.chromium.org/223333002/diff/20001/content/common/service_w...
File content/common/service_worker/embedded_worker_messages.h (right):

https://codereview.chromium.org/223333002/diff/20001/content/common/service_w...
content/common/service_worker/embedded_worker_messages.h:51: base::string16 /*
source_url */)
Would it be possible to pass a GURL here instead of a string16 for the url?

[nhiroki, 2014-04-08 08:44:18]

Thank you for reviewing.

https://codereview.chromium.org/223333002/diff/20001/content/common/service_w...
File content/common/service_worker/embedded_worker_messages.h (right):

https://codereview.chromium.org/223333002/diff/20001/content/common/service_w...
content/common/service_worker/embedded_worker_messages.h:51: base::string16 /*
source_url */)
On 2014/04/07 23:56:19, Tom Sepez wrote:
> Would it be possible to pass a GURL here instead of a string16 for the url?

Done.

[Tom Sepez, 2014-04-08 17:32:09]

Messages LGTM.

[nhiroki, 2014-04-08 17:38:36]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2014-04-08 17:38:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/223333002/90001

[commit-bot: I haz the power, 2014-04-08 17:38:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-08 17:38:46]

Failed to apply patch for
content/browser/service_worker/service_worker_dispatcher_host.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/browser/service_worker/service_worker_dispatcher_host.h
  Hunk #2 FAILED at 60.
  1 out of 2 hunks FAILED -- saving rejects to file
content/browser/service_worker/service_worker_dispatcher_host.h.rej

Patch:       content/browser/service_worker/service_worker_dispatcher_host.h
Index: content/browser/service_worker/service_worker_dispatcher_host.h
diff --git a/content/browser/service_worker/service_worker_dispatcher_host.h
b/content/browser/service_worker/service_worker_dispatcher_host.h
index
849ac217dfca3807d4912980ed1baadb3a38297d..b8ed78fd76442c9aacfd9fccc93d645886830d12
100644
--- a/content/browser/service_worker/service_worker_dispatcher_host.h
+++ b/content/browser/service_worker/service_worker_dispatcher_host.h
@@ -6,6 +6,7 @@
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_DISPATCHER_HOST_H_
 
 #include "base/memory/weak_ptr.h"
+#include "base/strings/string16.h"
 #include "content/browser/service_worker/service_worker_registration_status.h"
 #include "content/public/browser/browser_message_filter.h"
 
@@ -59,6 +60,11 @@ class CONTENT_EXPORT ServiceWorkerDispatcherHost : public
BrowserMessageFilter {
   void OnSendMessageToBrowser(int embedded_worker_id,
                               int request_id,
                               const IPC::Message& message);
+  void OnReportException(int embedded_worker_id,
+                         const base::string16& error_message,
+                         int line_number,
+                         int column_number,
+                         const GURL& source_url);
   void OnPostMessage(int64 registration_id,
                      const base::string16& message,
                      const std::vector<int>& sent_message_port_ids);

[nhiroki, 2014-04-08 22:04:36]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2014-04-08 22:06:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/223333002/110001

[commit-bot: I haz the power, 2014-04-09 00:30:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/223333002/110001

[commit-bot: I haz the power, 2014-04-09 00:54:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/223333002/110001

[commit-bot: I haz the power, 2014-04-09 01:05:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/223333002/110001

[commit-bot: I haz the power, 2014-04-09 01:25:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/223333002/110001

[commit-bot: I haz the power, 2014-04-09 01:36:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/223333002/110001

[commit-bot: I haz the power, 2014-04-09 01:47:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/223333002/110001

[commit-bot: I haz the power, 2014-04-09 01:58:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/223333002/110001

[commit-bot: I haz the power, 2014-04-09 02:17:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/223333002/110001

[commit-bot: I haz the power, 2014-04-09 04:03:25]

Change committed as 262606