Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 223333002: SW: Propagate errors/exceptions from service worker to browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_dispatcher_host.cc
diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc
index dd29cfc9246a89e8c3086331eb93792b3b3683f8..6999e9d84866b23cc7391abf79cfa86f7cf1a91f 100644
--- a/content/browser/service_worker/service_worker_dispatcher_host.cc
+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc
@@ -4,6 +4,7 @@
#include "content/browser/service_worker/service_worker_dispatcher_host.h"
+#include "base/logging.h"
#include "base/strings/utf_string_conversions.h"
#include "content/browser/message_port_message_filter.h"
#include "content/browser/message_port_service.h"
@@ -100,6 +101,8 @@ bool ServiceWorkerDispatcherHost::OnMessageReceived(
OnWorkerStopped)
IPC_MESSAGE_HANDLER(EmbeddedWorkerHostMsg_SendMessageToBrowser,
OnSendMessageToBrowser)
+ IPC_MESSAGE_HANDLER(EmbeddedWorkerHostMsg_ReportException,
+ OnReportException)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
@@ -291,6 +294,18 @@ void ServiceWorkerDispatcherHost::OnSendMessageToBrowser(
embedded_worker_id, request_id, message);
}
+void ServiceWorkerDispatcherHost::OnReportException(
+ int embedded_worker_id,
+ const base::string16& error_message,
+ int line_number,
+ int column_number,
+ const GURL& source_url) {
+ // TODO(horo, nhiroki): Show the error on serviceworker-internals
+ // (http://crbug.com/359517).
+ DVLOG(2) << "[Error] " << error_message << " (" << source_url
+ << ":" << line_number << "," << column_number << ")";
+}
+
void ServiceWorkerDispatcherHost::UnregistrationComplete(
int32 thread_id,
int32 request_id,

Powered by Google App Engine
This is Rietveld 408576698