chrome/browser/ui/cocoa/website_settings/permission_prompt_impl_views_mac.mm - Issue 2233293003: Position Mac permission bubbles on the left when in fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_prompt_impl_views_mac.mm

Issue 2233293003: Position Mac permission bubbles on the left when in fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/website_settings/permission_prompt_impl_views_mac.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_prompt_impl_views_mac.mm b/chrome/browser/ui/cocoa/website_settings/permission_prompt_impl_views_mac.mm

index 91311bd1d066d3c0b6ad20022986d49fd00a025a..518e5b819b4e5089aa4797fd8fde655565b3006d 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_prompt_impl_views_mac.mm

+++ b/chrome/browser/ui/cocoa/website_settings/permission_prompt_impl_views_mac.mm

@@ -28,9 +28,7 @@

}

views::BubbleBorder::Arrow PermissionPromptImpl::GetAnchorArrow() {

- return [PermissionBubbleController hasVisibleLocationBarForBrowser:browser_]

- ? views::BubbleBorder::TOP_LEFT

- : views::BubbleBorder::NONE;

+ return views::BubbleBorder::TOP_LEFT;

}

// static

« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm ('k') | no next file » | no next file with comments »