chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm - Issue 2233293003: Position Mac permission bubbles on the left when in fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm

Issue 2233293003: Position Mac permission bubbles on the left when in fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/website_settings/permission_prompt_impl_views_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm

index eaf37cfaf0c48b48f252a0bec9a7b82e0352fe6d..b3bd40c1c0fea6cb85669cecb7fa26916a9c7832 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm

@@ -38,6 +38,7 @@ - (void)onAllow:(id)sender;

- (void)onBlock:(id)sender;

- (void)onCustomize:(id)sender;

- (void)onCheckboxChanged:(id)sender;

++ (NSInteger)getFullscreenLeftOffset;

@end

@interface SplitBlockButton (ExposedForTesting)

@@ -374,10 +375,12 @@ void ChangePermissionMenuSelection(NSButton* menu_button, int next_title_id) {

NSPoint anchor = [controller_ getExpectedAnchorPoint];

- // Expected anchor location will be top center when there's no location bar.

+ // Expected anchor location will be top left when there's no location bar.

NSWindow* window = browser()->window()->GetNativeWindow();

- NSRect frame = [window frame];

- NSPoint expected = NSMakePoint(frame.size.width / 2, frame.size.height);

+ NSRect frame = [[window contentView] frame];

+ NSPoint expected = NSMakePoint(

+ NSMinX(frame) + [PermissionBubbleController getFullscreenLeftOffset],

+ NSMaxY(frame));

expected = ui::ConvertPointFromWindowToScreen(window, expected);

EXPECT_NSEQ(expected, anchor);

}