Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3050)

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm

Issue 2233293003: Position Mac permission bubbles on the left when in fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix MacViews bubbles Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
index eaf37cfaf0c48b48f252a0bec9a7b82e0352fe6d..f5f2189aa04c6361c5c4684362f94819c4526c27 100644
--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
@@ -376,8 +376,10 @@ void ChangePermissionMenuSelection(NSButton* menu_button, int next_title_id) {
// Expected anchor location will be top center when there's no location bar.
tapted 2016/08/12 04:25:39 nit: update comment
benwells 2016/08/12 06:29:44 Done.
benwells 2016/08/12 06:29:44 Done.
NSWindow* window = browser()->window()->GetNativeWindow();
- NSRect frame = [window frame];
- NSPoint expected = NSMakePoint(frame.size.width / 2, frame.size.height);
+ NSRect frame = [[window contentView] frame];
+ NSPoint expected = NSMakePoint(
+ NSMinX(frame) + [PermissionBubbleController getFullscreenLeftOffset],
+ frame.size.height);
tapted 2016/08/12 04:25:39 nit: `frame.size.height` should probably be NSMaxY
benwells 2016/08/12 06:29:44 Done.
expected = ui::ConvertPointFromWindowToScreen(window, expected);
EXPECT_NSEQ(expected, anchor);
}

Powered by Google App Engine
This is Rietveld 408576698