Position Mac permission bubbles on the left when in fullscreen.

chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h"
 
 #include <Carbon/Carbon.h>
 
 #include "base/mac/foundation_util.h"
 #import "base/mac/scoped_objc_class_swizzler.h"
@@ skipping 18 matching lines @@
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #import "ui/events/test/cocoa_test_event_utils.h"
 
 @class ConstrainedWindowButton;
 
 @interface PermissionBubbleController (ExposedForTesting)
 - (void)ok:(id)sender;
 - (void)onAllow:(id)sender;
 - (void)onBlock:(id)sender;
 - (void)onCustomize:(id)sender;

[tapted, 2016/08/12 04:25:39]

(and here).  Although the obvious flaw is that `onCustomize` and
`onCheckboxChanged` don't actually exist any more - I think they can be deleted

 - (void)onCheckboxChanged:(id)sender;
 @end
 
 @interface SplitBlockButton (ExposedForTesting)
 - (NSMenu*)menu;
 @end
 
 @interface MockBubbleYesLocationBar : NSObject
 @end
 
@@ skipping 317 matching lines @@
   EXPECT_NSEQ(expected, anchor);
 }
 
 TEST_F(PermissionBubbleControllerTest, AnchorPositionWithoutLocationBar) {
   base::mac::ScopedObjCClassSwizzler locationSwizzle(
       [PermissionBubbleController class], [MockBubbleNoLocationBar class],
       @selector(hasVisibleLocationBarForBrowser:));
 
   NSPoint anchor = [controller_ getExpectedAnchorPoint];
 
   // Expected anchor location will be top center when there's no location bar.

[tapted, 2016/08/12 04:25:39]

nit: update comment

[benwells, 2016/08/12 06:29:44]

Done.

[benwells, 2016/08/12 06:29:44]

Done.

   NSWindow* window = browser()->window()->GetNativeWindow();
-  NSRect frame = [window frame];
-  NSPoint expected = NSMakePoint(frame.size.width / 2, frame.size.height);
+  NSRect frame = [[window contentView] frame];
+  NSPoint expected = NSMakePoint(
+      NSMinX(frame) + [PermissionBubbleController getFullscreenLeftOffset],
+      frame.size.height);

[tapted, 2016/08/12 04:25:39]

nit: `frame.size.height` should probably be NSMaxY..  (the height works, but in
theory it wouldn't always be so in a dual-screen setup)

[benwells, 2016/08/12 06:29:44]

Done.

   expected = ui::ConvertPointFromWindowToScreen(window, expected);
   EXPECT_NSEQ(expected, anchor);
 }
 
 TEST_F(PermissionBubbleControllerTest,
     AnchorPositionDifferentWithAndWithoutLocationBar) {
   NSPoint withLocationBar;
   {
     base::mac::ScopedObjCClassSwizzler locationSwizzle(
         [PermissionBubbleController class], [MockBubbleYesLocationBar class],
         @selector(hasVisibleLocationBarForBrowser:));
     withLocationBar = [controller_ getExpectedAnchorPoint];
   }
 
   NSPoint withoutLocationBar;
   {
     base::mac::ScopedObjCClassSwizzler locationSwizzle(
         [PermissionBubbleController class], [MockBubbleNoLocationBar class],
         @selector(hasVisibleLocationBarForBrowser:));
     withoutLocationBar = [controller_ getExpectedAnchorPoint];
   }
 
   // The bubble should be in different places depending if the location bar is
   // available or not.
   EXPECT_NSNE(withLocationBar, withoutLocationBar);
 }