content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.h - Issue 2233153002: IndexedDB: WrapUnique(new T(args..)) -> MakeUnique<T>(args...)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.h

Issue 2233153002: IndexedDB: WrapUnique(new T(args..)) -> MakeUnique<T>(args...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/list_set_unittest.cc ('k') | content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.h

diff --git a/content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.h b/content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.h

index 2f9151691e6ddf6243d88b42acc4f40405e01369..3f4296f7e55d212f4f0232d7f66acb73656cc746 100644

--- a/content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.h

+++ b/content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.h

@@ -41,7 +41,7 @@ class MockBrowserTestIndexedDBClassFactory : public IndexedDBClassFactory {

MockBrowserTestIndexedDBClassFactory();

~MockBrowserTestIndexedDBClassFactory() override;

- IndexedDBDatabase* CreateIndexedDBDatabase(

+ scoped_refptr<IndexedDBDatabase> CreateIndexedDBDatabase(

const base::string16& name,

IndexedDBBackingStore* backing_store,

IndexedDBFactory* factory,

@@ -52,8 +52,9 @@ class MockBrowserTestIndexedDBClassFactory : public IndexedDBClassFactory {

const std::set<int64_t>& scope,

blink::WebIDBTransactionMode mode,

IndexedDBBackingStore::Transaction* backing_store_transaction) override;

- LevelDBTransaction* CreateLevelDBTransaction(LevelDBDatabase* db) override;

- LevelDBIteratorImpl* CreateIteratorImpl(

+ scoped_refptr<LevelDBTransaction> CreateLevelDBTransaction(

+ LevelDBDatabase* db) override;

+ std::unique_ptr<LevelDBIteratorImpl> CreateIteratorImpl(

std::unique_ptr<leveldb::Iterator> iterator) override;

void FailOperation(FailClass failure_class,