content/browser/indexed_db/list_set_unittest.cc - Issue 2233153002: IndexedDB: WrapUnique(new T(args..)) -> MakeUnique<T>(args...)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/list_set_unittest.cc

Issue 2233153002: IndexedDB: WrapUnique(new T(args..)) -> MakeUnique<T>(args...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/leveldb/leveldb_transaction.cc ('k') | content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/list_set_unittest.cc

diff --git a/content/browser/indexed_db/list_set_unittest.cc b/content/browser/indexed_db/list_set_unittest.cc

index 293330da5ca7887ee73a48d2aa01f4012dae7f30..642486640feccc8d5e084cdf0c54e4629fc6a503 100644

--- a/content/browser/indexed_db/list_set_unittest.cc

+++ b/content/browser/indexed_db/list_set_unittest.cc

@@ -6,6 +6,7 @@

#include <memory>

+#include "base/memory/ptr_util.h"

#include "base/memory/ref_counted.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -148,9 +149,9 @@ TEST(ListSetTest, ListSetObject) {

}

TEST(ListSetTest, ListSetPointer) {

- std::unique_ptr<Wrapped<int>> w0(new Wrapped<int>(0));

- std::unique_ptr<Wrapped<int>> w1(new Wrapped<int>(1));

- std::unique_ptr<Wrapped<int>> w2(new Wrapped<int>(2));

+ std::unique_ptr<Wrapped<int>> w0 = base::MakeUnique<Wrapped<int>>(0);

+ std::unique_ptr<Wrapped<int>> w1 = base::MakeUnique<Wrapped<int>>(1);

+ std::unique_ptr<Wrapped<int>> w2 = base::MakeUnique<Wrapped<int>>(2);

list_set<Wrapped<int>*> set;

EXPECT_EQ(0u, set.size());