chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h - Issue 2233123003: Fix many memory leaks in chrome/browser/ui/cocoa/omnibox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h

Issue 2233123003: Fix many memory leaks in chrome/browser/ui/cocoa/omnibox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from rsesek. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm ('k') | chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h

index 07daf9b470da28dd2841e6c2c8b52b51c1d92e7a..fa110bf967f9ccb9ee0a45305b398661f1c5d8bf 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h

@@ -17,7 +17,7 @@ class AutocompleteResult;

class OmniboxPopupViewMac;

@interface OmniboxPopupTableController

- : NSViewController<NSTableViewDelegate, NSTableViewDataSource> {

+ : NSObject<NSTableViewDelegate, NSTableViewDataSource> {

@private

base::scoped_nsobject<NSArray> array_;

NSInteger hoveredIndex_;

« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm ('k') | chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm » ('j') | no next file with comments »