components/safe_browsing_db/database_manager_unittest.cc - Issue 2233103002: Move full hash caching logic to v4_get_hash_protocol_manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/database_manager_unittest.cc

Issue 2233103002: Move full hash caching logic to v4_get_hash_protocol_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/safe_browsing_db/database_manager.cc ('K') | « components/safe_browsing_db/database_manager.cc ('k') | components/safe_browsing_db/v4_get_hash_protocol_manager.h » ('j') | components/safe_browsing_db/v4_get_hash_protocol_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/database_manager_unittest.cc

diff --git a/components/safe_browsing_db/database_manager_unittest.cc b/components/safe_browsing_db/database_manager_unittest.cc

index 3c862e65bb871054eb4cd5d703421f1b820edf12..dfde708a5f027a897fc6866939743c10c086f971 100644

--- a/components/safe_browsing_db/database_manager_unittest.cc

+++ b/components/safe_browsing_db/database_manager_unittest.cc

@@ -258,7 +258,7 @@ TEST_F(SafeBrowsingDatabaseManagerTest, CancelApiCheck) {

EXPECT_EQ(0ul, permissions.size());

EXPECT_FALSE(client.callback_invoked());

}

+/*

Nathan Parker 2016/08/15 19:54:47 What's this for? This should be moved or removed.

TEST_F(SafeBrowsingDatabaseManagerTest, ResultsAreCached) {

TestClient client;

const GURL url("https://www.example.com/more");

@@ -536,5 +536,6 @@ TEST_F(SafeBrowsingDatabaseManagerTest, CachedResultsAreEvicted) {

EXPECT_EQ(base::Time::Max(),

entry->second.full_hashes[0].cache_expire_after);

}

+*/

} // namespace safe_browsing