Move full hash caching logic to v4_get_hash_protocol_manager

components/safe_browsing_db/database_manager_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/safe_browsing_db/database_manager.h"
 
 #include <stddef.h>
 
 #include <set>
 #include <string>
@@ skipping 240 matching lines @@
   pm->SetDelaySeconds(100);
 
   EXPECT_FALSE(db_manager_->CheckApiBlacklistUrl(url, &client));
   EXPECT_TRUE(db_manager_->CancelApiCheck(&client));
   base::RunLoop().RunUntilIdle();
 
   const std::set<std::string>& permissions = client.GetBlockedPermissions();
   EXPECT_EQ(0ul, permissions.size());
   EXPECT_FALSE(client.callback_invoked());
 }
-
+/*

[Nathan Parker, 2016/08/15 19:54:47]

What's this for?  This should be moved or removed.

 TEST_F(SafeBrowsingDatabaseManagerTest, ResultsAreCached) {
   TestClient client;
   const GURL url("https://www.example.com/more");
   TestV4GetHashProtocolManager* pm = static_cast<TestV4GetHashProtocolManager*>(
       db_manager_->v4_get_hash_protocol_manager_);
   base::Time now = base::Time::UnixEpoch();
   SBFullHashResult full_hash_result;
   full_hash_result.hash = SBFullHashForString("example.com/");
   full_hash_result.metadata.api_permissions.insert("GEOLOCATION");
   full_hash_result.cache_expire_after = now + base::TimeDelta::FromMinutes(3);
@@ skipping 257 matching lines @@
   EXPECT_EQ(1ul, cache.size());
   entry = cache.find(full_hash_result.hash.prefix);
   EXPECT_NE(cache.end(), entry);
   EXPECT_EQ(epoch, entry->second.expire_after);
   EXPECT_EQ(1ul, entry->second.full_hashes.size());
   EXPECT_TRUE(SBFullHashEqual(full_hash_result.hash,
                               entry->second.full_hashes[0].hash));
   EXPECT_EQ(base::Time::Max(),
             entry->second.full_hashes[0].cache_expire_after);
 }
+*/
 
 }  // namespace safe_browsing