tools/metrics/histograms/histograms.xml - Issue 2233103002: Move full hash caching logic to v4_get_hash_protocol_manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2233103002: Move full hash caching logic to v4_get_hash_protocol_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bring back the histogram to check if there were any hits in the response from the server Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index de0654004ee5c288b0d9d634c631dbe0d26d27e0..287570719f66d1312ce9df4b8ac94642fd41b9af 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -49621,12 +49621,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<histogram name="SafeBrowsing.V4FullHashCacheResult"

enum="SafeBrowsingV4FullHashCacheResult">

<owner>kcarattini@chromium.org</owner>

+ <owner>vakh@chromium.org</owner>

<summary>Track cache hits for V4 full hashes.</summary>

</histogram>

<histogram name="SafeBrowsing.V4GetHashCheckResult"

enum="SafeBrowsingV4GetHashCheckResult">

<owner>kcarattini@chromium.org</owner>

+ <owner>vakh@chromium.org</owner>

<summary>Track get hash response hits for V4 full hash requests.</summary>

</histogram>

@@ -92486,6 +92488,8 @@ To add a new entry, add it with any value and run test to compute valid value.

+ <int value="6" label="UNEXPECTED_METADATA_VALUE_ERROR"/>

+ <int value="7" label="NO_THREAT_ERROR"/>

</enum>

« components/safe_browsing_db/v4_get_hash_protocol_manager.cc ('K') | « components/safe_browsing_db/v4_store.cc ('k') | no next file » | no next file with comments »