components/safe_browsing_db/v4_store.cc - Issue 2233103002: Move full hash caching logic to v4_get_hash_protocol_manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_store.cc

Issue 2233103002: Move full hash caching logic to v4_get_hash_protocol_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bring back the histogram to check if there were any hits in the response from the server Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/safe_browsing_db/v4_get_hash_protocol_manager.cc ('K') | « components/safe_browsing_db/v4_store.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/v4_store.cc

diff --git a/components/safe_browsing_db/v4_store.cc b/components/safe_browsing_db/v4_store.cc

index 4746d608a6bbcbc79fdf3741eec1d252b9b104ca..e34cb6f47e9dbf6754ea45f1a26d2f223e6148db 100644

--- a/components/safe_browsing_db/v4_store.cc

+++ b/components/safe_browsing_db/v4_store.cc

@@ -23,13 +23,6 @@ const uint32_t kFileMagic = 0x600D71FE;

const uint32_t kFileVersion = 9;

-// The minimum expected size (in bytes) of a hash-prefix.

-const uint32_t kMinHashPrefixLength = 4;

-// The maximum expected size (in bytes) of a hash-prefix. This represents the

-// length of a SHA256 hash.

-const uint32_t kMaxHashPrefixLength = 32;

void RecordStoreReadResult(StoreReadResult result) {

UMA_HISTOGRAM_ENUMERATION("SafeBrowsing.V4StoreReadResult", result,

STORE_READ_RESULT_MAX);