blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java - Issue 2233023002: Adding BlimpNavigationController to Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java

Issue 2233023002: Adding BlimpNavigationController to Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nav_handler_remove

Patch Set: @nyquist feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java ('k') | blimp/client/core/contents/android/blimp_contents_factory.cc » ('j') | blimp/client/core/contents/blimp_navigation_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java

diff --git a/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java b/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java

index 2afdeb31dde7db3e94cec6163ec05c395dd33f66..2aeffd191825dd300574534a6c0dbbd0d5396f01 100644

--- a/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java

+++ b/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java

@@ -54,11 +54,14 @@ public class DummyBlimpClientContext implements BlimpClientContext {

}

@Override

- public void attachBlimpPreferences(PreferenceFragment fragment,

- BlimpSettingsCallbacks callbacks) {

+ public boolean isBlimpEnabled() {

+ return false;

}

@Override

- public void setDelegate(BlimpClientContextDelegate delegate) {

- }

+ public void attachBlimpPreferences(

+ PreferenceFragment fragment, BlimpSettingsCallbacks callbacks) {}

+ @Override

+ public void setDelegate(BlimpClientContextDelegate delegate) {}

}