blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java - Issue 2233023002: Adding BlimpNavigationController to Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java

Issue 2233023002: Adding BlimpNavigationController to Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nav_handler_remove

Patch Set: @nyquist feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/core/android/blimp_client_context_impl_android.cc ('k') | blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java » ('j') | blimp/client/core/contents/blimp_navigation_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java

diff --git a/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java b/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java

index 29f17a3cf98bdcfc5e44f387151450dfab8fe0f8..09f090e5549d6385fc5f2c709e9e678baff3314a 100644

--- a/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java

+++ b/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java

@@ -67,8 +67,13 @@ public class BlimpClientContextImpl implements BlimpClientContext {

}

@Override

- public void attachBlimpPreferences(PreferenceFragment fragment,

- BlimpSettingsCallbacks callbacks) {

+ public boolean isBlimpEnabled() {

+ return false;

+ }

+ @Override

+ public void attachBlimpPreferences(

+ PreferenceFragment fragment, BlimpSettingsCallbacks callbacks) {

AboutBlimpPreferences.addBlimpPreferences(fragment);

AboutBlimpPreferences.registerCallback(callbacks);

}