Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2104)

Unified Diff: blimp/client/core/contents/blimp_navigation_controller_impl.cc

Issue 2233023002: Adding BlimpNavigationController to Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nav_handler_remove
Patch Set: Fixing unit tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/blimp_navigation_controller_impl.cc
diff --git a/blimp/client/core/contents/blimp_navigation_controller_impl.cc b/blimp/client/core/contents/blimp_navigation_controller_impl.cc
index c8209610b823ef926fba44bdc27325f39766f2e0..65492ee68b90674a540ca8eae3c0cdcfb5852503 100644
--- a/blimp/client/core/contents/blimp_navigation_controller_impl.cc
+++ b/blimp/client/core/contents/blimp_navigation_controller_impl.cc
@@ -42,12 +42,12 @@ void BlimpNavigationControllerImpl::Reload() {
bool BlimpNavigationControllerImpl::CanGoBack() const {
NOTIMPLEMENTED();
- return false;
+ return true;
}
bool BlimpNavigationControllerImpl::CanGoForward() const {
NOTIMPLEMENTED();
- return false;
+ return true;
}
void BlimpNavigationControllerImpl::GoBack() {
@@ -62,7 +62,12 @@ const GURL& BlimpNavigationControllerImpl::GetURL() {
return current_url_;
}
+const std::string& BlimpNavigationControllerImpl::GetTitle() {
+ return current_title_;
+}
+
void BlimpNavigationControllerImpl::OnUrlChanged(int tab_id, const GURL& url) {
+ current_url_ = url;
delegate_->OnNavigationStateChanged();
}
@@ -73,6 +78,7 @@ void BlimpNavigationControllerImpl::OnFaviconChanged(int tab_id,
void BlimpNavigationControllerImpl::OnTitleChanged(int tab_id,
const std::string& title) {
+ current_title_ = title;
delegate_->OnNavigationStateChanged();
}

Powered by Google App Engine
This is Rietveld 408576698